openssh: Allow all openssl 3.1.x releases

[klausholstjacobsen]

openssh/*

Changed requirements to allow all openssl/3.1.x releases and not only 3.1.0

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[AbrilRBS]

Thanks!

[jcar87]

checking for openssl/opensslv.h... yes
checking OpenSSL header version... 30200010 (OpenSSL 3.2.1 30 Jan 2024)
checking for OpenSSL_version... yes
checking for OpenSSL_version_num... yes
checking OpenSSL library version... openssh/9.1p1: 
configure: error: Unknown/unsupported OpenSSL version ("30200010 (OpenSSL 3.2.1 30 Jan 2024)")

Interesting error here - if it is the code from here: https://github.com/openssh/openssh-portable/blob/1c0d81357921f8d3bab06841df649edac515ae5b/configure.ac#L2864-L2888
then I don't see why any version of >3 would fail, other than 3.0.4 due to a vulnerability.

Will investigate!

Edit: oh, the error is quite clear. It is somehow comparing the string openssh/9.1p1 with the known/compatible versions of OpenSSL... which of course fails. It expects something that starts with 3

[klausholstjacobsen]

Added differentiated openssl requirements for 9.1p1 and 9.6p1

[jcar87]

Added differentiated openssl requirements for 9.1p1 and 9.6p1

It looks like they have recently added this: openssh/openssh-portable@2eded55

with

OpenSSL has moved to 3.4 which we don't currently accept. Based on
the OpenSSL versioning policy[0] it looks like all of the 3.x versions
should work with OpenSSH, so remove the distinction in configure and
accept all of them.

I think this confirms that it's okay for the recipe to simply resolve to any version in the 3.x series.

Another solution for the version that is failing:

    def source(self):
        get(self, **self.conan_data["sources"][self.version], strip_root=True)
        if self.version == "9.1p1":
            # See https://github.com/openssh/openssh-portable/commit/2eded551ba96e66bc3afbbcc883812c2eac02bd7
            replace_in_file(self, join(self.source_folder, "configure"), "300*", "30*")

[jcar87]

version 9.1p1 would have not accepted version 3.2,
and version 9.6p1 would have not accepted versions higher than than 3.2, so the recipe would've started failing once OpenSSL 3.3 or higher was released. Newer versions should already have the fix to accept any in the 3.x range, as per the OpenSSL versioning guidelines

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 7 (fd701afaaa29a304d45af871fffdabc6e03a1b52):

• openssh/9.6p1:
  All packages built successfully! (All logs)

• openssh/9.1p1:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (fd701afaaa29a304d45af871fffdabc6e03a1b52):

• openssh/9.6p1:
  All packages built successfully! (All logs)

• openssh/9.1p1:
  All packages built successfully! (All logs)