Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onetbb: 2020.x - enable cross building on Macos #14136

Merged
merged 7 commits into from
Dec 1, 2022

Conversation

Nekto89
Copy link
Contributor

@Nekto89 Nekto89 commented Nov 10, 2022

Specify library name and version: onetbb/2020.x

Try to build onetbb for ios.
https://github.com/oneapi-src/oneTBB/blob/v2020.3/build/ios.macos.inc


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Nov 10, 2022

I detected other pull requests that are modifying onetbb/2020.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit e70a8d2
onetbb/2020.2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2019_u9
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.

@Nekto89 Nekto89 changed the title onetbb: 2020.x - add flag for building for iOS onetbb: 2020.x - enable cross building on Macos Nov 11, 2022
@Nekto89 Nekto89 marked this pull request as ready for review November 11, 2022 08:26
@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Nov 14, 2022
@ghost ghost mentioned this pull request Nov 14, 2022
4 tasks
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@Nekto89 Please, consider Nekto89#3 It should fix import errors.

@Nekto89
Copy link
Contributor Author

Nekto89 commented Nov 25, 2022

@Nekto89 Please, consider Nekto89#3 It should fix import errors.

wasn't this change already done in another PR that adds cppstd? Do you want me to abandon 1 PR and merge all changes? I'm just used to incremental individual commits that can already bring value.

@conan-center-bot

This comment has been minimized.

Use rm_safe
[onetbb] Update outdated imports and fix linter errors
@uilianries
Copy link
Member

It failed due a git operation. I just restarted it now.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prince-chrismc
Copy link
Contributor

wasn't this change already done in another PR that adds cppstd? Do you want me to abandon 1 PR and merge all changes? I'm just used to incremental individual commits that can already bring value.

Please make one PR with all the changes in the future 🙏 it's faster to review and save work updating the recipe twice.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (f38710382f2eb635a3cc750eec7ed8414ccfbcb9):

  • onetbb/2020.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py", line 6, in <module>
        from conans import tools as legacy_tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • onetbb/2020.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py", line 6, in <module>
        from conans import tools as legacy_tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • onetbb/2020.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py", line 6, in <module>
        from conans import tools as legacy_tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • onetbb/2020.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py", line 6, in <module>
        from conans import tools as legacy_tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • onetbb/2019_u9@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14136/recipes/onetbb/2020.x/conanfile.py", line 6, in <module>
        from conans import tools as legacy_tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Hooks produced the following warnings for commit f387103
onetbb/2020.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2019_u9
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 352f106 into conan-io:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants