Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onetbb: 2020.x - pass cppstd to make #13552

Merged
merged 3 commits into from
Nov 29, 2022
Merged

onetbb: 2020.x - pass cppstd to make #13552

merged 3 commits into from
Nov 29, 2022

Conversation

Nekto89
Copy link
Contributor

@Nekto89 Nekto89 commented Oct 17, 2022

Specify library name and version: onetbb/2020.x

Closes #13519

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Oct 17, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 791784e
onetbb/2020.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2019_u9 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries reviewed Oct 18, 2022
View reviewed changes
recipes/onetbb/2020.x/conanfile.py
@@ -195,6 +195,17 @@ def add_flag(name, value):
extra += " compiler=icl"
else:
extra += " compiler=cl"
cxx_std_flag = tools.cppstd_flag(self.settings)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool is not ported to new tools, which means, it will be deprecated soon if not ported.

@uilianries
Copy link
Member

Asked to port cppstd_flag method: conan-io/conan#12324

Please, take a look on linter errors, some imports need to be updated too.

@Nekto89
Copy link
Contributor Author

Nekto89 commented Oct 18, 2022

Asked to port cppstd_flag method: conan-io/conan#12324

Please, take a look on linter errors, some imports need to be updated too.

Can't this be completed without migration to conan v2?

@prince-chrismc
Copy link
Contributor

Can't this be completed without migration to conan v2?

None of this recipe has been ported, I think this is fine

@uilianries
Copy link
Member

@Nekto89 Totally fine using that method. In the future we can re-visit this recipe and update again.

This was referenced Nov 10, 2022
Closed
Merged
prince-chrismc
prince-chrismc previously approved these changes Nov 14, 2022
View reviewed changes
@ghost
Copy link

ghost commented Nov 14, 2022

I detected other pull requests that are modifying onetbb/2020.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@uilianries
update tools
5822f1f 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@Nekto89 Please, consider Nekto89#2

@Nekto89
Merge pull request #2 from uilianries/onetbb/2020_3_stdver
e716474 
onetbb: Update import tools and fix linter errors
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 2 (e716474ebe1301a8d63de11f0ed5fb0275cd0073):

  • onetbb/2020.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py", line 7, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • onetbb/2020.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py", line 7, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • onetbb/2020.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py", line 7, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • onetbb/2020.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py", line 7, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • onetbb/2019_u9@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13552/recipes/onetbb/2020.x/conanfile.py", line 7, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit e716474
onetbb/2020.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2020.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
onetbb/2019_u9 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbbmalloc_proxy_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libtbb_debug.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 113e38a into conan-io:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] onetbb/2020.3: compiler.cppstd isn't used
4 participants
@Nekto89 @conan-center-bot @uilianries @prince-chrismc