Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#13422) bump proj 9.1.0 #14090

Closed

Conversation

ElliotMugner
Copy link
Contributor

@ElliotMugner ElliotMugner commented Nov 7, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Nov 7, 2022

I detected other pull requests that are modifying proj/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

This reverts commit 36771d3.
This reverts commit 18b43f6.
@conan-center-bot

This comment has been minimized.

@paulharris
Copy link
Contributor

You should be able to click "Close Pull Request" and then "Reopen Pull Request" to trigger a rebuild in the CI.

@paulharris
Copy link
Contributor

Also note that you can consider building on top of my work once #13795 has merged.

@ElliotMugner ElliotMugner reopened this Nov 8, 2022
@ElliotMugner
Copy link
Contributor Author

ElliotMugner commented Nov 8, 2022

You should be able to click "Close Pull Request" and then "Reopen Pull Request" to trigger a rebuild in the CI.

Thanks a lot 👍

Also note that you can consider building on top of my work once #13795 has merged.

@paulharris Maybe we could consider adding this new version to your Pull request ? Very few changes as you can see.

@ElliotMugner ElliotMugner reopened this Nov 8, 2022
@paulharris
Copy link
Contributor

@paulharris Maybe we could consider adding this new version to your Pull request ? Very few changes as you can see.

@ElliotMugner ok, I've cherry-picked your commits into mine, and fixed up the patches.
Thanks for starting the work, makes it easier to get started.

It looks like your patch didn't work? At least not for me, locally.
Here's a tip for getting patches to work (for the future - I wish someone had told me before),
conan's patch-apply is really strict. No fuzzing allowed.
So, I cd into the cache dir, make a copy of the source.
Then use standard linux patch to apply the patch to the copy, fix up any problems,
and then diff -ru oldsource newsource > the_target_patch.patch.
Then I clean the patch a little (remove whatever extra rows, adjust the filenames) and you are good to go.

Also, I'd suggest you avoid special chars like ( ) # in your branch names, it is harder to type as you have to put the branch name into quotes on the command line when using git.

I have pushed the 9.1.0 changes shortly, please check my PR, clone by branch and see if it works for you :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 11 (0e365055c4e7bc2fcd46b3e789a3aecc1cea27e3):

  • proj/9.1.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 98a1f79da60dd0992b1799e43184fac50130e752:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    proj:shared=False
    
    [...]
    libtiff/4.3.0: Retrieving package dc394aa91906cdf56c44eca30fcc5e6778a7a0e3 from remote 'conan-center' 
    Downloading conanmanifest.txt
    Downloading conaninfo.txt
    Downloading conan_package.tgz
    libtiff/4.3.0: Package installed dc394aa91906cdf56c44eca30fcc5e6778a7a0e3
    libtiff/4.3.0: Downloaded package revision d79f06a7cb0e1ac54d8b530455831c67
    jbig/20160605: Appending PATH environment variable: /home/conan/w/prod/BuildSingleReference/.conan/data/jbig/20160605/_/_/package/3e46a2250aa0ec61108950304328fd94c0aed0c1/bin
    sqlite3/3.38.5: Appending PATH env var with : /home/conan/w/prod/BuildSingleReference/.conan/data/sqlite3/3.38.5/_/_/package/8fc930bdbf940331d9f322f454eac3dd06fd27e8/bin
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    proj/9.1.0: Configuring sources in /home/conan/w/prod/BuildSingleReference/.conan/data/proj/9.1.0/_/_/source
    
    [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
    [HOOK - conan-center.py] post_source(): [CPPSTD MANAGEMENT (KB-H022)] OK
    [HOOK - conan-center.py] post_source(): [SHORT_PATHS USAGE (KB-H066)] OK
    proj/9.1.0: Copying sources to build folder
    proj/9.1.0: Building your package in /home/conan/w/prod/BuildSingleReference/.conan/data/proj/9.1.0/_/_/build/98a1f79da60dd0992b1799e43184fac50130e752
    proj/9.1.0: Generator cmake_find_package created Findnlohmann_json.cmake
    proj/9.1.0: Generator cmake_find_package created FindSQLite3.cmake
    proj/9.1.0: Generator cmake_find_package created FindTIFF.cmake
    proj/9.1.0: Generator cmake_find_package created FindCURL.cmake
    proj/9.1.0: Generator cmake_find_package created FindZLIB.cmake
    proj/9.1.0: Generator cmake_find_package created Findlibdeflate.cmake
    proj/9.1.0: Generator cmake_find_package created FindLibLZMA.cmake
    proj/9.1.0: Generator cmake_find_package created FindJPEG.cmake
    proj/9.1.0: Generator cmake_find_package created Findjbig.cmake
    proj/9.1.0: Generator cmake_find_package created Findzstd.cmake
    proj/9.1.0: Generator cmake_find_package created FindWebP.cmake
    proj/9.1.0: Generator cmake_find_package created FindOpenSSL.cmake
    proj/9.1.0: Generator cmake created conanbuildinfo.cmake
    proj/9.1.0: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    proj/9.1.0: Calling build()
    �[1m�[36mpatches/0001-use-cmake-targets-9.1.0.patch: source file is different - b'src/lib_proj.cmake'�[0m
    proj/9.1.0: 
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch: file 1/1:	 b'src/lib_proj.cmake'�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:  hunk no.1 doesn't match source file at line 446�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:   expected: b'  target_link_libraries(proj PRIVATE ${CMAKE_THREAD_LIBS_INIT})'�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:   actual  : b'if(USE_THREAD AND Threads_FOUND AND CMAKE_USE_PTHREADS_INIT)'�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch: file 1/1:	 b'src/lib_proj.cmake'�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:  hunk no.2 doesn't match source file at line 456�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:   expected: b''�[0m
    �[1m�[33mWARN: patches/0001-use-cmake-targets-9.1.0.patch:   actual  : b'    PRIVATE $<BUILD_INTERFACE:nlohmann_json::nlohmann_json>)'�[0m
    proj/9.1.0: ERROR: Package '98a1f79da60dd0992b1799e43184fac50130e752' build failed
    proj/9.1.0: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/proj/9.1.0/_/_/build/98a1f79da60dd0992b1799e43184fac50130e752
    ERROR: proj/9.1.0: Error in build() method, line 81
    	self._patch_sources()
    while calling '_patch_sources', line 89
    	tools.patch(**patch)
    	ConanException: Failed to apply patch: patches/0001-use-cmake-targets-9.1.0.patch
    
  • proj/6.3.1@:
    Didn't run or was cancelled before finishing

  • proj/9.0.0@:
    Didn't run or was cancelled before finishing

  • proj/8.1.1@:
    Didn't run or was cancelled before finishing

  • proj/9.0.1@:
    Didn't run or was cancelled before finishing

  • proj/8.1.0@:
    Didn't run or was cancelled before finishing

  • proj/8.2.0@:
    Didn't run or was cancelled before finishing

  • proj/8.0.1@:
    Didn't run or was cancelled before finishing

  • proj/8.0.0@:
    Didn't run or was cancelled before finishing

  • proj/7.2.1@:
    Didn't run or was cancelled before finishing

  • proj/8.2.1@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Dec 11, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants