Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj: support for conan v2 #13795

Merged
merged 28 commits into from
Dec 16, 2022
Merged

Conversation

paulharris
Copy link
Contributor

@paulharris paulharris commented Oct 27, 2022

A nice cmake project, but this is consumed a lot of other difference recipes.
I wonder about bin paths, virtual run envs and other such things will work properly with this new recipe.
How best to test?

closes #14090
closes #13422

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

Seems like the deps need some love

@paulharris paulharris closed this Nov 5, 2022
@paulharris paulharris reopened this Nov 5, 2022
@paulharris paulharris closed this Nov 5, 2022
@paulharris paulharris reopened this Nov 5, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Nov 7, 2022

I detected other pull requests that are modifying proj/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@paulharris
Copy link
Contributor Author

paulharris commented Nov 8, 2022

Question: VTK imports proj as
find_package(LibPROJ (perhaps flags here))
and LibPROJ::LibPROJ
and checks LibPROJ_MAJOR_VERSION

The recipe exports find_package(proj) and PROJ::proj and proj_MAJOR_VERSION

What is the best way to create an alias for this? Or should we patch VTK instead?

Note, same problem exists with libharu
VTK: LibHaru LibHaru::LibHaru
conan: libharu libharu::libharu

Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlite3 must be added to build requirements unconditionally now.

recipes/proj/all/conanfile.py Outdated Show resolved Hide resolved
recipes/proj/all/conanfile.py Outdated Show resolved Hide resolved
paulharris and others added 2 commits December 1, 2022 11:12
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 13, 2022

@paulharris please consider paulharris#4

@paulharris
Copy link
Contributor Author

I don't cross-compile so I'll trust that you know what you are doing!

Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplification in 9.0.1 patch, needs to be done in all patches. Basically, except CONAN_PKG::sqlite3 to replace by SQLite::SQLite3, there was no other modification needed in these patches (just maybe a find_package for nlohmann_json in old proj versions).

@conan-center-bot

This comment has been minimized.

paulharris and others added 2 commits December 14, 2022 20:54
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@paulharris
Copy link
Contributor Author

@SpaceIm see changes to 6.x.x patch... you mean like this?
Should we specify MODULE or CONFIG in the find_package() calls?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 24 (8b06e6de14ff0421d65d677690655aea9a8f371b):

  • proj/6.3.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.2.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.1.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/7.2.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/9.1.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.1.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.0.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.2.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/8.0.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/9.0.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    
  • proj/9.0.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13795/recipes/proj/all/conanfile.py", line 3, in <module>
        from conans.tools import stdcpp_library
    ModuleNotFoundError: No module named 'conans.tools'
    

@conan-center-bot conan-center-bot merged commit 9d67090 into conan-io:master Dec 16, 2022
@paulharris paulharris deleted the proj-conan-v2 branch December 16, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] Proj/9.1.0
6 participants