-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proj: support for conan v2 #13795
proj: support for conan v2 #13795
Conversation
This comment has been minimized.
This comment has been minimized.
Seems like the deps need some love |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying proj/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
Question: VTK imports proj as The recipe exports What is the best way to create an alias for this? Or should we patch VTK instead? Note, same problem exists with libharu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sqlite3 must be added to build requirements unconditionally now.
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@paulharris please consider paulharris#4 |
proj: fix sqlite3 utilily injection
I don't cross-compile so I'll trust that you know what you are doing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplification in 9.0.1 patch, needs to be done in all patches. Basically, except CONAN_PKG::sqlite3
to replace by SQLite::SQLite3
, there was no other modification needed in these patches (just maybe a find_package for nlohmann_json in old proj versions).
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@SpaceIm see changes to 6.x.x patch... you mean like this? |
Conan v1 pipelineAll green in build 24 (
|
A nice cmake project, but this is consumed a lot of other difference recipes.
I wonder about bin paths, virtual run envs and other such things will work properly with this new recipe.
How best to test?
closes #14090
closes #13422