Add package cpplogging #14043

EmilienBINET · 2022-11-05T13:08:55Z

Specify library name and version: cpplogging/1.0.3.0
requires cppcommon/1.0.3.0
the previous versions (cpplogging/1.0.0.0 and cpplogging/1.0.1.0) require cppcommon/1.0.2.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

EmilienBINET · 2022-11-13T09:04:54Z

Build currently fails because version 1.0.3.0 requires cppcommon/1.0.3.0 to be merged (PR #14038)

prince-chrismc

This is amazing work but it's a touch behind our best practices and current recommendations -- i'd like to encourage you to look at the cmake template we have to maybe update this so it's not using deprecated features

Also we typically dont add older point releases unless they are specific required.

Id suggest keeping on the latest -- they are very similar so I would not imagine you need an older point release

prince-chrismc · 2022-11-18T18:07:41Z

recipes/cpplogging/all/conanfile.py

@@ -0,0 +1,100 @@
+from conans import CMake


Given this is a new recipe I would be really appreciated if you used the newer build helpers

This is deprecated and will be removed soon... you can see the template for a good example

conan-center-index/docs/package_templates/cmake_package/all/conanfile.py

Line 7 in 3bf8c6b

from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain, cmake_layout

Thanks for the template, I'll look at it.
I left that one line because I struggled a bit when I tried to remove it and could not make the recipe to work.

recipes/cpplogging/all/conanfile.py

prince-chrismc · 2022-11-18T18:10:57Z

recipes/cpplogging/all/conanfile.py

+            del self.options.fPIC
+
+        if self.settings.compiler.get_safe("cppstd"):
+            build.check_min_cppstd(self, "17")


Looking over the project is does not say this and the GitHub actions build without it so I am surprsed to see this here 🤔

Can you share why you are adding this?

The project uses std::string_view which was added to the stl in C++17.

fair enough, but it should be pointed by the upstream, there is no reference about C++ standard there.

I just created the PR chronoxor/CppLogging#5 to enforce the standard as requirement.

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

EmilienBINET · 2022-11-18T19:17:42Z

Thanks for the compliment, but the credit goes to the one that made the cppcommon and cppserver recipes.
I used them as template as the creator of those 3 libraries uses the same way to code his projects.

conan-center-bot · 2022-11-19T01:52:22Z

Conan v1 pipeline

All green in build 7 (6395f842bbf5dd96803a79fd2f2f64cddfed2285):

cpplogging/1.0.0.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py", line 1, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpplogging/1.0.1.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py", line 1, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpplogging/1.0.3.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-14043/recipes/cpplogging/all/conanfile.py", line 1, in <module>
    from conans import CMake
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

uilianries

Thank you for your contributions, please, consider ConanCenterIndex templates in the future, they are more aligned with new features and will save your time when writing a new recipe from scratch.

uilianries · 2022-11-29T09:57:09Z

recipes/cpplogging/all/conandata.yml

+  "1.0.1.0":
+    url: "https://github.com/chronoxor/CppLogging/archive/refs/tags/1.0.1.0.tar.gz"
+    sha256: "46247873f8137ff1511222a85f34a8d54d5f804a93e3f04c6476bf61d8db7113"
+  "1.0.3.0":


Do you really need all these three versions? Otherwise, please, keep only the latest. We want to avoid more and more versions which are outdated and not downloaded. They cost CI time, resources and storage.

uilianries · 2022-11-29T10:08:25Z

recipes/cpplogging/all/conanfile.py

+            del self.options.fPIC
+
+        if self.settings.compiler.get_safe("cppstd"):
+            build.check_min_cppstd(self, "17")


fair enough, but it should be pointed by the upstream, there is no reference about C++ standard there.

uilianries · 2022-11-29T10:12:01Z

recipes/cpplogging/all/conanfile.py

+    def _configure_cmake(self):
+        if not self._cmake:
+            self._cmake = CMake(self)
+            self._cmake.definitions["CPPLOGGING_MODULE"] = "OFF"


Suggested change

self._cmake.definitions["CPPLOGGING_MODULE"] = "OFF"

self._cmake.definitions["CPPLOGGING_MODULE"] = False

self._cmake.definitions["BUILD_TESTING"] = False

Enforce disabling tests

uilianries · 2022-11-29T10:20:46Z

recipes/cpplogging/all/conanfile.py

+            del self.options.fPIC
+
+        if self.settings.compiler.get_safe("cppstd"):
+            build.check_min_cppstd(self, "17")


I just created the PR chronoxor/CppLogging#5 to enforce the standard as requirement.

uilianries · 2022-11-29T10:21:30Z

recipes/cpplogging/all/conanfile.py

+        files.get(self, **self.conan_data["sources"][self.version])
+        extracted_dir = glob.glob("CppLogging-*")[0]
+        os.rename(extracted_dir, self._source_subfolder)


Suggested change

files.get(self, **self.conan_data["sources"][self.version])

extracted_dir = glob.glob("CppLogging-*")[0]

os.rename(extracted_dir, self._source_subfolder)

files.get(self, **self.conan_data["sources"][self.version], destination=self._source_subfolder, strip_root=True)

uilianries · 2022-11-29T10:30:56Z

recipes/cpplogging/all/test_package/conanfile.py

+    # VirtualBuildEnv and VirtualRunEnv can be avoided if "tools.env.virtualenv:auto_use" is defined
+    # (it will be defined in Conan 2.0)
+    generators = "CMakeDeps", "CMakeToolchain", "VirtualBuildEnv", "VirtualRunEnv"
+    apply_env = False


Suggested change

# VirtualBuildEnv and VirtualRunEnv can be avoided if "tools.env.virtualenv:auto_use" is defined

# (it will be defined in Conan 2.0)

generators = "CMakeDeps", "CMakeToolchain", "VirtualBuildEnv", "VirtualRunEnv"

apply_env = False

generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv"

You are not testing a build tool

uilianries · 2022-11-29T10:31:11Z

recipes/cpplogging/all/test_package/conanfile.py

+        cmake_layout(self)
+
+    def test(self):
+        if not cross_building(self):


Suggested change

if not cross_building(self):

if can_run(self):

uilianries · 2022-11-29T10:32:23Z

recipes/cpplogging/all/test_v1_package/conanfile.py

+
+from conan import ConanFile
+from conan.tools.cmake import CMake, cmake_layout
+from conan.tools.build import cross_building
+
+
+class CpploggingTestConan(ConanFile):
+    settings = "os", "compiler", "build_type", "arch"
+    # VirtualBuildEnv and VirtualRunEnv can be avoided if "tools.env.virtualenv:auto_use" is defined
+    # (it will be defined in Conan 2.0)
+    generators = "CMakeDeps", "CMakeToolchain", "VirtualBuildEnv", "VirtualRunEnv"
+    apply_env = False
+    test_type = "explicit"
+
+    def requirements(self):
+        self.requires(self.tested_reference_str)
+
+    def build(self):
+        cmake = CMake(self)
+        cmake.configure()
+        cmake.build()
+
+    def layout(self):
+        cmake_layout(self)
+
+    def test(self):
+        if not cross_building(self):
+            cmd = os.path.join(self.cpp.build.bindirs[0], "console")
+            self.run(cmd, env="conanrun")


Suggested change

from conan import ConanFile

from conan.tools.cmake import CMake, cmake_layout

from conan.tools.build import cross_building

class CpploggingTestConan(ConanFile):

settings = "os", "compiler", "build_type", "arch"

# VirtualBuildEnv and VirtualRunEnv can be avoided if "tools.env.virtualenv:auto_use" is defined

# (it will be defined in Conan 2.0)

generators = "CMakeDeps", "CMakeToolchain", "VirtualBuildEnv", "VirtualRunEnv"

apply_env = False

test_type = "explicit"

def requirements(self):

self.requires(self.tested_reference_str)

def build(self):

cmake = CMake(self)

cmake.configure()

cmake.build()

def layout(self):

cmake_layout(self)

def test(self):

if not cross_building(self):

cmd = os.path.join(self.cpp.build.bindirs[0], "console")

self.run(cmd, env="conanrun")

from conans import ConanFile, CMake

from conan.tools.build import cross_building

class TestPackageV1Conan(ConanFile):

settings = "os", "arch", "compiler", "build_type"

generators = "cmake", "cmake_find_package_multi"

def build(self):

cmake = CMake(self)

cmake.configure()

cmake.build()

def test(self):

if not cross_building(self):

bin_path = os.path.join("bin", "console")

self.run(bin_path, run_environment=True)

Keep test v1 only with legacy tools, so we can prove that the recipe is cross-compatible.

uilianries · 2022-11-29T10:34:29Z

recipes/cpplogging/all/test_v1_package/src/console.cpp

@@ -0,0 +1,42 @@
+/*!


Delete this file, you can re-use directly from test_package.

uilianries · 2022-11-29T10:36:23Z

recipes/cpplogging/all/test_v1_package/CMakeLists.txt

+cmake_minimum_required(VERSION 3.15)
+project(PackageTest CXX)
+
+find_package(cpplogging CONFIG REQUIRED)
+
+add_executable(console src/console.cpp)
+target_link_libraries(console cpplogging::cpplogging)
+
+target_compile_features(console PRIVATE cxx_std_17)


Suggested change

cmake_minimum_required(VERSION 3.15)

project(PackageTest CXX)

find_package(cpplogging CONFIG REQUIRED)

add_executable(console src/console.cpp)

target_link_libraries(console cpplogging::cpplogging)

target_compile_features(console PRIVATE cxx_std_17)

cmake_minimum_required(VERSION 3.1)

project(test_package)

include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)

conan_basic_setup(TARGETS)

add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../test_package/

${CMAKE_CURRENT_BINARY_DIR}/test_package/)

Re-use the implementation from test_package/CMakeLists.txt, but conserve conan_basic_setup() It's deprecated due CMakeDeps, so it's only useful here.

stale · 2023-01-16T01:46:03Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

EmilienBINET · 2023-01-22T10:28:39Z

A little message to say I have not forsaken the subject. I just could not find time to do it.
I hope I will be able to get back into it from the and of the month.

stale · 2023-03-12T15:31:43Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Add package cpplogging

67940f0

conan-center-bot added the User-approval pending label Nov 5, 2022

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Nov 5, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Nov 5, 2022

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

conan-center-bot added Failed and removed User-approval pending labels Nov 7, 2022

This comment has been minimized.

Sign in to view

Using 'conan' for tools instead of 'conans'

7081a31

This comment has been minimized.

Sign in to view

EmilienBINET marked this pull request as draft November 11, 2022 17:21

Fix build errors

6c8942c

This comment has been minimized.

Sign in to view

EmilienBINET marked this pull request as ready for review November 13, 2022 09:03

Reduce minimum Cmake version to fit conancenter CI

1049275

This comment has been minimized.

Sign in to view

Fix patch error

1f09cac

conan-center-bot removed the Failed label Nov 17, 2022

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Nov 18, 2022

View reviewed changes

Update recipes/cpplogging/all/conanfile.py

6395f84

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

uilianries reviewed Nov 29, 2022

View reviewed changes

conan-center-bot requested a review from danimtb December 6, 2022 11:58

conan-center-bot requested a review from jcar87 December 15, 2022 11:58

stale bot added the stale label Jan 16, 2023

stale bot closed this Mar 12, 2023

valgur mentioned this pull request Jan 26, 2024

Stale recipe PRs possibly worth another look #22553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add package cpplogging #14043

Add package cpplogging #14043

EmilienBINET commented Nov 5, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

EmilienBINET commented Nov 13, 2022

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

prince-chrismc Nov 18, 2022

EmilienBINET Nov 18, 2022

prince-chrismc Nov 18, 2022

EmilienBINET Nov 18, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

EmilienBINET commented Nov 18, 2022

conan-center-bot commented Nov 19, 2022

uilianries left a comment

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

uilianries Nov 29, 2022

stale bot commented Jan 16, 2023

EmilienBINET commented Jan 22, 2023

stale bot commented Mar 12, 2023

	self._cmake.definitions["CPPLOGGING_MODULE"] = "OFF"
	self._cmake.definitions["CPPLOGGING_MODULE"] = False
	self._cmake.definitions["BUILD_TESTING"] = False

Add package cpplogging #14043

Add package cpplogging #14043

Conversation

EmilienBINET commented Nov 5, 2022

Specify library name and version: cpplogging/1.0.3.0 requires cppcommon/1.0.3.0 the previous versions (cpplogging/1.0.0.0 and cpplogging/1.0.1.0) require cppcommon/1.0.2.0

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

EmilienBINET commented Nov 13, 2022

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EmilienBINET commented Nov 18, 2022

conan-center-bot commented Nov 19, 2022

Conan v1 pipeline

uilianries left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jan 16, 2023

EmilienBINET commented Jan 22, 2023

stale bot commented Mar 12, 2023

Specify library name and version: cpplogging/1.0.3.0
requires cppcommon/1.0.3.0
the previous versions (cpplogging/1.0.0.0 and cpplogging/1.0.1.0) require cppcommon/1.0.2.0