Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare C++17 as mandatory #5

Closed
wants to merge 1 commit into from

Conversation

uilianries
Copy link

This project is using std::string_view feature, which is from C++17, but is not declared in CMake, neither documented in the README. For who is using latest versions of GCC, clang, ... it should not be a problem, because they already support C++17 as default standard version, but old compiler should break if the standard is not declared explicitly.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@chronoxor
Copy link
Owner

There is a C++20 enabled in SetCompilerFeatures.cmake

# Choose C++ standard
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_EXTENSIONS ON)

@uilianries
Copy link
Author

@chronoxor Thank you!

@uilianries uilianries closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants