[openjdk/xxx] Conan v2 migration #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 493461aopenjdk/16.0.1 |
uilianries
reviewed
Oct 26, 2022
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 4d3028dopenjdk/16.0.1 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5862740openjdk/16.0.1 |
prince-chrismc
previously approved these changes
Oct 30, 2022
|
Hi @jcar87! I think I misclicked and dismissed a review request that was addressed to you. |
|
This is towards #12888 🚀 |
uilianries
reviewed
Nov 3, 2022
|
|
||
| def package_info(self): | ||
| self.output.info("Creating JAVA_HOME environment variable with : {0}".format(self.package_folder)) | ||
| self.env_info.JAVA_HOME = self.package_folder |
There was a problem hiding this comment.
Keep env_info.JAVA_HOME, https://conan.io/center/openapi-generator is still not ported and will not work without it.
There was a problem hiding this comment.
Done here: 41fcb72
There was a problem hiding this comment.
I thought I wrote the openapi-generator recipe in a conan v2 compatible way.
Conan v1 pipelineAll green in build 8 (
|
Hooks produced the following warnings for commit 41fcb72openjdk/16.0.1 |
uilianries
approved these changes
Nov 7, 2022
prince-chrismc
approved these changes
Nov 7, 2022
|
Who should I ping to make this PR approved and merged ? |
|
@MartinDelille merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!