Add openapi-generator/6.0.1 #13691
Add openapi-generator/6.0.1 #13691
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| path=bin_path, | ||
| content=f"""\ | ||
| #!/bin/bash | ||
| java -jar {jar} $@ |
There was a problem hiding this comment.
What if java is not installed 🤔
There was a problem hiding this comment.
This thought did occur to me, too. I wasn't sure if perhaps we had any other Java packages around. Would this require a java/system package?
There was a problem hiding this comment.
Are not openjdk or openjdk-zulu packages enough?
There was a problem hiding this comment.
Had no idea we had an openjdk package. Nice!
There was a problem hiding this comment.
I would say this should have a require openjdk for it to make the most sense 😉 that's a great solution
(insert some meme about C++ being better than Java -- enjoy my bad jokes)
There was a problem hiding this comment.
I thought I would need to add openjdk as a requirement but I was confused how to do it: adding a tool_requires in requirements method ?)
Since the CI pass I decide to wait for your comment.
There was a problem hiding this comment.
Do you need java for runtime? If yes, add as regular self.requires in requirements(). Otherwise, tool_requires in build_requirements().
|
Jenkins is waiting on a MacOS machine... RIP |
I thought adding this tool would be a nightmare due to maven dependency but being able to handle prebuilt binaries makes it awesomely simple!