Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas:build_lapack should use gfortran from CCI #13169

Closed
wants to merge 3 commits into from
Closed

openblas:build_lapack should use gfortran from CCI #13169

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9555928
use conan fortran with build_lapack option
ggulgulia Sep 27, 2022
537e4c9
use fortran as build requirements
ggulgulia Sep 27, 2022
24bd4ca
use tools_requires for build requirement
ggulgulia Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions recipes/openblas/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ def configure(self):
if self.options.shared:
del self.options.fPIC

def requirements(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe gfortran is a build requirement, does not it? You want fortran to build lapack only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is true. I should use build_requires I suppose there.

if self.options.build_lapack:
self.requires("gfortran/10.2")
ggulgulia marked this conversation as resolved.
Show resolved Hide resolved

def validate(self):
if hasattr(self, "settings_build") and tools.cross_building(self, skip_x64_x86=True):
raise ConanInvalidConfiguration("Cross-building not implemented")
Expand Down