-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas:build_lapack should use gfortran from CCI #13169
openblas:build_lapack should use gfortran from CCI #13169
Conversation
recipes/openblas/all/conanfile.py
Outdated
@@ -50,6 +50,10 @@ def configure(self): | |||
if self.options.shared: | |||
del self.options.fPIC | |||
|
|||
def requirements(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe gfortran is a build requirement, does not it? You want fortran to build lapack only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is true. I should use build_requires I suppose there.
All green in build 1 (
|
I'm still not able to build openblas with lapack after the modifications. When I run the command
I get an error indicating that fortran compiler is not found
From our previous discussion on simbody MR, I conclude that we cannot change the option Build LogClick to expand log
|
Co-authored-by: Uilian Ries <uilianries@gmail.com>
How does the project test for the compiler?
I would assume there's some hint or path check and we need to give the CMake the location of the compiler? |
Likely, |
That's not being set
|
Wow, I had no idea we had a |
@jwillikers There is a long history behind gfortran package. It was totally broken for many months, then we converted to a pre-built tool recipe. |
I detected other pull requests that are modifying openblas/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
I think the gfortran package is still broken as per #14120, even after making the necessary modifications to export |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Library name openblas packages
build_lapack
, which on many systems may not available out of the box