bzip3: add recipe #11612

toge · 2022-07-09T13:37:40Z

Specify library name and version: bzip3/1.1.4

Bzip3 is a compression library.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

recipes/bzip3/all/CMakeLists.txt

Co-authored-by: SSE4 <tomskside@gmail.com>

github-actions · 2022-07-09T20:34:27Z

Hooks produced the following warnings for commit b23484d

bzip3/1.1.4

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbzip3.so' links to system library 'm' but it is not in cpp_info.system_libs.

recipes/bzip3/all/CMakeLists.txt

recipes/bzip3/all/test_package/test_package.c

…er-index into bzip3-add-recipe

jwillikers

Awesome! Thanks!

github-actions · 2022-07-11T19:30:40Z

Hooks produced the following warnings for commit ffd8b97

bzip3/1.1.4

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbzip3.so' links to system library 'm' but it is not in cpp_info.system_libs.

prince-chrismc

Maybe we can sneak in the missing system lib?

Hooks produced the following warnings for commit ffd8b97
bzip3/1.1.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbzip3.so' links to system library 'm' but it is not in cpp_info.system_libs.

recipes/bzip3/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

conan-center-bot · 2022-07-13T13:52:47Z

All green in build 6 (650e049568aec7e2396d65bc261bdbf11e873ef1):

bzip3/1.1.4@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11612/recipes/bzip3/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11612/recipes/bzip3/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11612/recipes/bzip3/all/conanfile.py", line 2, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

SpaceIm · 2022-07-14T22:18:00Z

recipes/bzip3/all/CMakeLists.txt

+    C_EXTENSIONS OFF
+)
+if (with_thread)
+    target_compile_definitions(bzip3 PRIVATE "PTHREAD")


you should add:

find_package(Threads REQUIRED) target_link_libraries(bzip3 PRIVATE Threads::Threads)

SpaceIm · 2022-07-14T22:19:15Z

recipes/bzip3/all/CMakeLists.txt

+if (WITH_UTIL)
+    install(
+        TARGETS bzip3_cmd
+        RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}


breaks iOS

should be:

DESTINATION ${CMAKE_INSTALL_BINDIR}

SpaceIm · 2022-07-14T22:20:54Z

recipes/bzip3/all/conanfile.py

+        if self.settings.os not in ["Linux", "FreeBSD"]:
+            del self.options.with_thread


should be in config_options()

why only Linux & FreeBSD? Should be deleted for Windows only (and actually it should work for MinGW with pthread)

SpaceIm · 2022-07-14T22:22:27Z

recipes/bzip3/all/conanfile.py

+        cmake = self._configure_cmake()
+        cmake.install()
+
+    def package_info(self):


you should add:

self.cpp_info.set_property("pkg_config_name", "bzip3")

see https://github.com/kspalaiologos/bzip3/blob/1.1.4/bzip3.pc.in

* bzip3: add recipe * set c_std_99 features for `restrict` keyword * make restrict macro * update cmake required version Co-authored-by: SSE4 <tomskside@gmail.com> * add const * modernize CMakeLists.txt * link pthread only on with_thread=True Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: SSE4 <tomskside@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

…update-from-conan-io * 'master' of github.com:conan-io/conan-center-index: (1322 commits) (conan-io#11692) [bot] Add Access Request users (2022-07-14) (conan-io#11691) gettext: update dependencies (conan-io#11685) libcurl: update openssl (conan-io#11688) s2n: update openssl (conan-io#11687) sqlite3: add version 3.39.1 (conan-io#11683) docs: add a link the list of reviewers (conan-io#11682) certify - bump deps (conan-io#11673) amqp-cpp - bump deps (conan-io#11672) msix - bump deps (conan-io#11580) wayland: Switch to MesonToolchain generator to allow cross-compiling (conan-io#11557) spirv-tools package 1.3.216 has the wrong git hash (conan-io#11439) openssl: Fix option no_md2 (conan-io#11680) cassandra-cpp-driver - bump deps (conan-io#11671) arrow: update dependencies (conan-io#11675) aws-c-cal - bump deps (conan-io#11677) brynet - bump deps (conan-io#11662) doc: link to cci-pending-review github page (conan-io#11612) bzip3: add recipe (conan-io#11071) [libjpeg] Use SPDX license identifer (conan-io#11478) libcurl: add version 7.84.0 ...

bzip3: add recipe

7c381c6

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 9, 2022

set c_std_99 features for restrict keyword

cd24385

conan-center-bot removed the Failed label Jul 9, 2022

github-actions bot mentioned this pull request Jul 9, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 9, 2022

make restrict macro

bf92102

conan-center-bot removed the Failed label Jul 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 9, 2022

SSE4 reviewed Jul 9, 2022

View reviewed changes

recipes/bzip3/all/CMakeLists.txt Outdated Show resolved Hide resolved

update cmake required version

b23484d

Co-authored-by: SSE4 <tomskside@gmail.com>

conan-center-bot removed the Failed label Jul 9, 2022

This comment has been minimized.

Sign in to view

danimtb previously approved these changes Jul 11, 2022

View reviewed changes

jwillikers reviewed Jul 11, 2022

View reviewed changes

recipes/bzip3/all/CMakeLists.txt Outdated Show resolved Hide resolved

recipes/bzip3/all/test_package/test_package.c Outdated Show resolved Hide resolved

toge added 3 commits July 12, 2022 03:02

add const

b3c3ec9

modernize CMakeLists.txt

b016f78

Merge branch 'bzip3-add-recipe' of https://github.com/toge/conan-cent…

ffd8b97

…er-index into bzip3-add-recipe

toge dismissed danimtb’s stale review via ffd8b97 July 11, 2022 18:02

jwillikers previously approved these changes Jul 11, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

SSE4 previously approved these changes Jul 11, 2022

View reviewed changes

prince-chrismc reviewed Jul 12, 2022

View reviewed changes

recipes/bzip3/all/conanfile.py Outdated Show resolved Hide resolved

link pthread only on with_thread=True

650e049

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

toge dismissed SSE4’s stale review via 650e049 July 13, 2022 12:47

toge dismissed jwillikers’s stale review via 650e049 July 13, 2022 12:47

jwillikers approved these changes Jul 13, 2022

View reviewed changes

SSE4 approved these changes Jul 13, 2022

View reviewed changes

prince-chrismc approved these changes Jul 13, 2022

View reviewed changes

conan-center-bot merged commit 6253a3c into conan-io:master Jul 13, 2022

SpaceIm reviewed Jul 14, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bzip3: add recipe #11612

bzip3: add recipe #11612

toge commented Jul 9, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jul 9, 2022

jwillikers left a comment

This comment has been minimized.

github-actions bot commented Jul 11, 2022

prince-chrismc left a comment

conan-center-bot commented Jul 13, 2022

SpaceIm Jul 14, 2022

SpaceIm Jul 14, 2022

SpaceIm Jul 14, 2022

SpaceIm Jul 14, 2022

		if self.settings.os not in ["Linux", "FreeBSD"]:
		del self.options.with_thread

bzip3: add recipe #11612

bzip3: add recipe #11612

Conversation

toge commented Jul 9, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jul 9, 2022

jwillikers left a comment

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Jul 11, 2022

prince-chrismc left a comment

Choose a reason for hiding this comment

conan-center-bot commented Jul 13, 2022

SpaceIm Jul 14, 2022

Choose a reason for hiding this comment

SpaceIm Jul 14, 2022

Choose a reason for hiding this comment

SpaceIm Jul 14, 2022

Choose a reason for hiding this comment

SpaceIm Jul 14, 2022

Choose a reason for hiding this comment