Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-tools package 1.3.216 has the wrong git hash #11557

Merged
merged 1 commit into from
Jul 14, 2022
Merged

spirv-tools package 1.3.216 has the wrong git hash #11557

merged 1 commit into from
Jul 14, 2022

Conversation

ntagliani
Copy link
Contributor

@ntagliani ntagliani commented Jul 5, 2022

Specify library name and version: spirv-tools/1.3.216

This fixes #11550 where the sha256 sum of the tarball changed after the original publication of the recipe


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jul 7, 2022

I detected other pull requests that are modifying spirv-tools/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ntagliani
Copy link
Contributor Author

Hi, is there anything that I can do to get the missing approvals?

@prince-chrismc
Copy link
Contributor

Can you please update the description to link the issue 🙏

You needs to have fixes #11550 for it to work. it's very picky https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@prince-chrismc
Copy link
Contributor

Hi, is there anything that I can do to get the missing approvals?

Nope! With two ticks the bot will merge it, you can see the process in https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed

@ntagliani ntagliani changed the title spirv-tools package 1.3.216 has the wrong git hash fixes #11550 spirv-tools package 1.3.216 has the wrong git hash Jul 13, 2022
@prince-chrismc
Copy link
Contributor

that's the title not the description 🙈

This drop drown should have an Edit option for you
image


PS congratz for opening your first PR 🚀

@ntagliani ntagliani changed the title fixes #11550 spirv-tools package 1.3.216 has the wrong git hash spirv-tools package 1.3.216 has the wrong git hash Jul 13, 2022
@ntagliani
Copy link
Contributor Author

Opsie… I did a quick change and didn’t think too much.
Sorry for that.
Would it be ok now or does it need to be outside of the text (sorry for the stupid question but it’s the first time that I use this feature)

@conan-center-bot
Copy link
Collaborator

All green in build 7 (125e0a60d69c53f7368cc72082a78192c448f5a3):

  • spirv-tools/1.3.216.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/1.3.211.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/1.3.204.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2019.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2021.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2020.5@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2021.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2021.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • spirv-tools/2020.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11557/recipes/spirv-tools/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools, CMake
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@conan-center-bot conan-center-bot merged commit 5dceccd into conan-io:master Jul 14, 2022
@prince-chrismc
Copy link
Contributor

No worries, it's a not very intuitive feature!

Looks like it worked when inline with text 🎉

Gratz on ur first pr here getting merged 😄

AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 29, 2022
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
…update-from-conan-io

* 'master' of github.com:conan-io/conan-center-index: (1322 commits)
  (conan-io#11692) [bot] Add Access Request users (2022-07-14)
  (conan-io#11691) gettext: update dependencies
  (conan-io#11685) libcurl: update openssl
  (conan-io#11688) s2n: update openssl
  (conan-io#11687) sqlite3: add version 3.39.1
  (conan-io#11683) docs: add a link the list of reviewers
  (conan-io#11682) certify - bump deps
  (conan-io#11673) amqp-cpp - bump deps
  (conan-io#11672) msix - bump deps
  (conan-io#11580) wayland: Switch to MesonToolchain generator to allow cross-compiling
  (conan-io#11557) spirv-tools package 1.3.216 has the wrong git hash
  (conan-io#11439) openssl: Fix option no_md2
  (conan-io#11680) cassandra-cpp-driver - bump deps
  (conan-io#11671) arrow: update dependencies
  (conan-io#11675) aws-c-cal - bump deps
  (conan-io#11677) brynet - bump deps
  (conan-io#11662) doc: link to cci-pending-review github page
  (conan-io#11612) bzip3: add recipe
  (conan-io#11071) [libjpeg] Use SPDX license identifer
  (conan-io#11478) libcurl: add version 7.84.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] spirv-tool/1.3.216.0 has the wrong sha256 hash and cannot be downloaded to be built
5 participants