Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11553 - ruby/3.1.0: build error on all platforms due to wrong prefix #11561

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Jul 6, 2022

Specify library name and version: ruby/3.1.0


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jmarrec
Copy link
Contributor Author

jmarrec commented Jul 6, 2022

I don't get the build error on mac. Somehow it's not getting the regular --enabled-shared --disable-static flags

"/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/ruby/3.1.0/_/_/build/966b66b567032e4599c3e963ffb9b3f225c09e74/source_subfolder/configure" '--disable-install-doc' '--prefix=/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/ruby/3.1.0/_/_/package/966b66b567032e4599c3e963ffb9b3f225c09e74' '--bindir=${prefix}/bin' '--sbindir=${prefix}/bin' '--libdir=${prefix}/lib' '--includedir=${prefix}/include' '--oldincludedir=${prefix}/include' '--datarootdir=${prefix}/res'

Locally I have an M1 mac, and it works plently fine.

$ conan create . ruby/3.1.0@ -b missing -b ruby -o ruby:shared=True

"/Users/julien/.conan/data/ruby/3.1.0/_/_/build/d35caaaeda1d80f8657c3b9f8b7e15f224f68699/source_subfolder/configure" '--disable-shared' '--enable-static' '--prefix=/' '--bindir=${prefix}/bin' '--sbindir=${prefix}/bin' '--libdir=${prefix}/lib' '--includedir=${prefix}/include' '--oldincludedir=${prefix}/include' '--disable-install-doc'

might be the conan version on the runner maybe?

@conan-center-bot
Copy link
Collaborator

All green in build 3 (44617d1076d90544cd36d69bb119c4022047c092):

  • ruby/3.1.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11561/recipes/ruby/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11561/recipes/ruby/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11561/recipes/ruby/all/conanfile.py", line 16, in <module>
        from conans import tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Hooks produced the following warnings for commit 44617d1
ruby/3.1.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 335eba1 into conan-io:master Jul 19, 2022
@jmarrec jmarrec deleted the 11553_ruby branch August 22, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] ruby/3.1.0: build error on all platforms due to wrong prefix
4 participants