Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby to 3.2 #4624

Closed
macumber opened this issue Jul 2, 2022 · 4 comments
Closed

Upgrade Ruby to 3.2 #4624

macumber opened this issue Jul 2, 2022 · 4 comments

Comments

@macumber
Copy link
Contributor

macumber commented Jul 2, 2022

Enhancement Request

Upgrade the embedded Ruby version to 3.1. This would align with future plans for integrating with SketchUp, https://forums.sketchup.com/t/ruby-3-is-coming-headers-and-libs-available/202102. I think their reasoning is pretty sound on picking 3.1 vs 3.0 (which Ubuntu 22.04 went with).

@macumber macumber added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jul 2, 2022
@jmarrec
Copy link
Collaborator

jmarrec commented Jul 5, 2022

That means we may be able to use the conan-center-index ruby recipe too, which starts at 3.1.0: https://github.com/conan-io/conan-center-index/blob/master/recipes/ruby/all/conanfile.py

At least use that as a basis for modernizing our own https://github.com/NREL/conan-openstudio-ruby/ which uses a CMake layer plus some .bat scripts on windows and is a pain to maintain. Ruby 3.x also is supposed to have made significant advances in properly supporting building with MSVC (the ruby/ruby github repo now has a MSVC runner for CI: https://github.com/ruby/ruby/blob/master/.github/workflows/windows.yml )

@tijcolem tijcolem added component - CLI and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jul 15, 2022
@tijcolem tijcolem added this to the OpenStudio SDK 3.6.0 milestone Jul 27, 2022
@tijcolem tijcolem self-assigned this Nov 2, 2022
@tijcolem tijcolem removed this from the OpenStudio SDK 3.6.0 milestone Mar 17, 2023
@tijcolem tijcolem added this to the OpenStudio SDK 3.7.0 milestone Apr 21, 2023
@DavidGoldwasser
Copy link
Collaborator

DavidGoldwasser commented Jun 20, 2023

We should tentatively plan to upgrade to 3.1 or 3.2. Can discuss offline if any complications of using 3.2 vs. 3.1. If I get public confirmation of some 3rd party tools Ruby version for next release I'll share that here.

@DavidGoldwasser DavidGoldwasser changed the title Upgrade Ruby to 3.1 Upgrade Ruby to 3.2 Jun 30, 2023
@DavidGoldwasser DavidGoldwasser removed this from the OpenStudio SDK 3.7.0 milestone Aug 25, 2023
@DavidGoldwasser DavidGoldwasser assigned jmarrec and unassigned tijcolem Dec 15, 2023
@jmarrec
Copy link
Collaborator

jmarrec commented Jan 12, 2024

for ref sketchup has a ruby 3.2 branch. https://github.com/SketchUp/ruby-c-extension-examples/tree/dev/ruby-3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants