New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gdk-pixbuf] remove clang exception #11436

Merged

conan-center-bot merged 5 commits into conan-io:master from planetmarshall:gdk-pixbuf-clang

Jul 13, 2022

Contributor

planetmarshall commented Jun 29, 2022 •

edited

Loading

Specify library name and version: gdk-pixbuf/*

Remove the clang exception for updated glib dependency

Workaround #10154 by adding the -rtlib=compiler-rt flag for Clang. Should also fix #11412

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

ghost mentioned this pull request

[service] Potentially conflicting recipes #3571

Closed

ghost commented Jun 29, 2022

I detected other pull requests that are modifying gdk-pixbuf/all recipe:

[gdk-pixbuf] link against older glib only when building debug version #11357

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

ghost mentioned this pull request

[gdk-pixbuf] link against older glib only when building debug version #11357

Closed

4 tasks

Contributor

theartful commented Jun 29, 2022

I tried to do this before submitting #11357, it worked on my main arch linux, but it failed on ubuntu 20.04 with the same error as discussed here #10154 (comment)

planetmarshall force-pushed the gdk-pixbuf-clang branch from cdcf743 to 81524c2 Compare

June 29, 2022 19:55

planetmarshall marked this pull request as ready for review

June 29, 2022 19:58


          [gdk-pixbuf] remove clang exception

5ab5dc2

planetmarshall force-pushed the gdk-pixbuf-clang branch from 81524c2 to 5ab5dc2 Compare

June 29, 2022 20:00

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

theartful reviewed

View reviewed changes

recipes/gdk-pixbuf/all/conanfile.py Outdated Show resolved Hide resolved

theartful reviewed

View reviewed changes

recipes/gdk-pixbuf/all/conanfile.py Show resolved Hide resolved

planetmarshall added 3 commits

June 29, 2022 22:26


          [gdk-pixelbuf] export compiler-rt flags

7c69579


          [gdk-pixbuf] test for presence of compiler-rt

23b4d83


          [gdk-pixbuf] remove extraneous file

afdb360

theartful reviewed

View reviewed changes

recipes/gdk-pixbuf/all/conanfile.py

                       args.append("--wrap-mode=nofallback")
                       meson.configure(defs=defs, build_folder=self._build_subfolder, source_folder=self._source_subfolder, pkg_config_paths=".", args=args)
                       return meson
                   def build(self):
+                      if self._requires_compiler_rt:
+                          self._test_for_compiler_rt()

Contributor

theartful Jun 30, 2022

maybe add this in validate function

Contributor Author

planetmarshall Jun 30, 2022

I did try that but unfortunately compiler information is not available to conan at that point.

I'm not sure what the best fix for this is - it has come up before. I might propose an upstream fix to glib to define __muloti4 itself if it isn't available but I'm not that familiar with the meson build system.

planetmarshall closed this

planetmarshall reopened this

This comment has been minimized.

Sign in to view


          [gdk-pixbuf] apply linter suggestions

dca0956

This comment has been minimized.

Sign in to view

conan-center-bot added Failed Unexpected Error labels

planetmarshall closed this

planetmarshall reopened this

conan-center-bot removed Unexpected Error Failed labels

Collaborator

conan-center-bot commented Jun 30, 2022

All green in build 8 (dca09569e287b64671a9882df605fd43bc2fe26e):

gdk-pixbuf/2.42.8@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, CMake, Meson, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

gdk-pixbuf/2.42.6@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, CMake, Meson, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

gdk-pixbuf/2.42.2@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, CMake, Meson, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

gdk-pixbuf/2.42.0@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, CMake, Meson, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

gdk-pixbuf/2.42.4@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11436/recipes/gdk-pixbuf/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, CMake, Meson, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

conan-center-bot requested a review from SSE4

July 1, 2022 12:02

Contributor Author

planetmarshall commented Jul 11, 2022

FYI CCI - would be good to get this reviewed and merged. Thanks.

planetmarshall mentioned this pull request

[gtk] add component support for gtk4 #11399

Closed

4 tasks

danimtb approved these changes

View reviewed changes

prince-chrismc approved these changes

View reviewed changes

conan-center-bot merged commit b6b9448 into conan-io:master

planetmarshall deleted the gdk-pixbuf-clang branch

July 13, 2022 20:00

AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request


          (conan-io#11436) [gdk-pixbuf] remove clang exception

1886de7

* [gdk-pixbuf] remove clang exception

* [gdk-pixelbuf] export compiler-rt flags

* [gdk-pixbuf] test for presence of compiler-rt

* [gdk-pixbuf] remove extraneous file

* [gdk-pixbuf] apply linter suggestions

planetmarshall mentioned this pull request

[gdk-pixbuf] update dependencies and modernize #13174

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet