Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdk-pixbuf: modernize #10154

Merged
merged 8 commits into from
Apr 22, 2022
Merged

gdk-pixbuf: modernize #10154

merged 8 commits into from
Apr 22, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 7, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@prince-chrismc prince-chrismc mentioned this pull request Apr 7, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Apr 7, 2022
@SpaceIm SpaceIm reopened this Apr 7, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Apr 7, 2022
@SpaceIm SpaceIm reopened this Apr 7, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
ericLemanissier
ericLemanissier reviewed Apr 14, 2022
View reviewed changes
recipes/gdk-pixbuf/all/conanfile.py Outdated
self.build_requires("meson/0.61.2")
self.build_requires("pkgconf/1.7.4")
if self.options.with_introspection:
self.build_requires("gobject-introspection/1.70.0")

def requirements(self):
self.requires("glib/2.70.4")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("glib/2.70.4")
self.requires("glib/2.72.0")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop, see previous commits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a comment on this line, or someone(including me) will inevitably try to bump it later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what is the interaction between glib and the LLVM issue posted above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this LLVM issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one in #10154 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides switching to compiler-rt, the workaround could be to define function __muloti4, e.g. like here:
https://opensource.apple.com/source/clang/clang-600.0.54/src/projects/compiler-rt/lib/muloti4.c.auto.html
the bug seems to be old enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d055044

@SpaceIm SpaceIm force-pushed the gdk-pixbuf-modernize branch from 44cdafb to f818112 Compare April 14, 2022 19:50
@SpaceIm SpaceIm requested a review from uilianries April 14, 2022 19:51
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 15, 2022

Well, let's keep previous version of glib unconditionally because it was not the goal this PR and I don't have the time to fix this.

@ericLemanissier
Copy link
Contributor

ok, this is caught by the new hook

[HOOK - conan-center.py] post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\gio-2.0-0.dll' links to system library 'iphlpapi' but it is not in cpp_info.system_libs.
[HOOK - conan-center.py] post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\gio-2.0-0.dll' links to system library 'dnsapi' but it is not in cpp_info.system_libs.
[HOOK - conan-center.py] post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\gio-2.0-0.dll' links to system library 'shlwapi' but it is not in cpp_info.system_libs.

I'll do a PR. We are in a bad situation with overriding of glib, with the change of default from shared to static starting with 2.71.1..

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot requested a review from SSE4 April 18, 2022 12:02
@ericLemanissier ericLemanissier mentioned this pull request Apr 21, 2022
Closed
4 tasks
@ericLemanissier
Copy link
Contributor

FYI, all the build with --require-override glib/2.72.0 passed on https://github.com/eirikb/proof-of-conan/actions/runs/2202500966 . I'm giving it a spin on #10427

@conan-center-bot
Copy link
Collaborator

All green in build 19 (00a5b6f159f770fa5978f71a8188b066c78fd0b5):

  • gdk-pixbuf/2.42.4@:
    All packages built successfully! (All logs)

  • gdk-pixbuf/2.42.0@:
    All packages built successfully! (All logs)

  • gdk-pixbuf/2.42.6@:
    All packages built successfully! (All logs)

  • gdk-pixbuf/2.42.2@:
    All packages built successfully! (All logs)

@SSE4
Copy link
Contributor

SSE4 commented Apr 22, 2022

ok, this is caught by the new hook

great, it provides some useful feedback, and doesn't appear to break anything. great job @madebr !

@conan-center-bot conan-center-bot merged commit 51b1ced into conan-io:master Apr 22, 2022
@ericLemanissier
Copy link
Contributor

ok, this is caught by the new hook

great, it provides some useful feedback, and doesn't appear to break anything. great job @madebr !

The hook is great indeed, but honestly it is close to useless because you have to go search for these warnings. hence my PR #10395

@SpaceIm SpaceIm deleted the gdk-pixbuf-modernize branch April 22, 2022 14:47
This was referenced Jun 29, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @ericLemanissier @SSE4 @uilianries