-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gtsam 4.1.1 #11122
Merged
Merged
Added gtsam 4.1.1 #11122
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
diff --git a/cmake/HandleBoost.cmake b/cmake/HandleBoost.cmake | ||
--- a/cmake/HandleBoost.cmake | ||
+++ b/cmake/HandleBoost.cmake | ||
@@ -25,13 +25,7 @@ endif() | ||
set(BOOST_FIND_MINIMUM_VERSION 1.65) | ||
set(BOOST_FIND_MINIMUM_COMPONENTS serialization system filesystem thread program_options date_time timer chrono regex) | ||
|
||
-find_package(Boost ${BOOST_FIND_MINIMUM_VERSION} COMPONENTS ${BOOST_FIND_MINIMUM_COMPONENTS}) | ||
- | ||
-# Required components | ||
-if(NOT Boost_SERIALIZATION_LIBRARY OR NOT Boost_SYSTEM_LIBRARY OR NOT Boost_FILESYSTEM_LIBRARY OR | ||
- NOT Boost_THREAD_LIBRARY OR NOT Boost_DATE_TIME_LIBRARY) | ||
- message(FATAL_ERROR "Missing required Boost components >= v1.65, please install/upgrade Boost or configure your search paths.") | ||
-endif() | ||
+find_package(Boost ${BOOST_FIND_MINIMUM_VERSION} COMPONENTS ${BOOST_FIND_MINIMUM_COMPONENTS} REQUIRED) | ||
|
||
option(GTSAM_DISABLE_NEW_TIMERS "Disables using Boost.chrono for timing" OFF) | ||
# Allow for not using the timer libraries on boost < 1.48 (GTSAM timing code falls back to old timer library) | ||
@@ -47,7 +41,7 @@ if (GTSAM_DISABLE_NEW_TIMERS) | ||
message("WARNING: GTSAM timing instrumentation manually disabled") | ||
list_append_cache(GTSAM_COMPILE_DEFINITIONS_PUBLIC DGTSAM_DISABLE_NEW_TIMERS) | ||
else() | ||
- if(Boost_TIMER_LIBRARY) | ||
+ if(TARGET Boost::timer) | ||
list(APPEND GTSAM_BOOST_LIBRARIES Boost::timer Boost::chrono) | ||
else() | ||
list(APPEND GTSAM_BOOST_LIBRARIES rt) # When using the header-only boost timer library, need -lrt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -4,7 +4,6 @@ cmake_minimum_required(VERSION 3.0) | ||
# new feature to Cmake Version > 2.8.12 | ||
# Mac ONLY. Define Relative Path on Mac OS | ||
if(NOT DEFINED CMAKE_MACOSX_RPATH) | ||
- set(CMAKE_MACOSX_RPATH 0) | ||
endif() | ||
|
||
# Set the version number for the library | ||
diff --git a/gtsam/3rdparty/metis/libmetis/CMakeLists.txt b/gtsam/3rdparty/metis/libmetis/CMakeLists.txt | ||
--- a/gtsam/3rdparty/metis/libmetis/CMakeLists.txt | ||
+++ b/gtsam/3rdparty/metis/libmetis/CMakeLists.txt | ||
@@ -16,12 +16,6 @@ if(WIN32) | ||
RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/../../../bin") | ||
endif() | ||
|
||
-if (APPLE) | ||
- set_target_properties(metis-gtsam PROPERTIES | ||
- INSTALL_NAME_DIR | ||
- "${CMAKE_INSTALL_PREFIX}/lib") | ||
- endif() | ||
- | ||
install(TARGETS metis-gtsam EXPORT GTSAM-exports | ||
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
versions: | ||
"4.1.1": | ||
folder: all | ||
"4.0.3": | ||
folder: all | ||
"4.0.2": | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.conan.io/en/latest/reference/conanfile/tools/microsoft.html#conan-tools-microsoft-is-msvc
Don't forget to add the new import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Pushed a commit which replaces the manual checks with
is_msvc()
now.