Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gtsam 4.1.1 #11122

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Added gtsam 4.1.1 #11122

merged 4 commits into from
Jul 25, 2022

Conversation

martinvl
Copy link
Contributor

Specify library name and version: gtsam/4.1.1

Bumps GTSAM to 4.1.1.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@martinvl martinvl mentioned this pull request Jun 10, 2022
Closed
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@uilianries
Copy link
Member

@martinvl Please, don't forget to sign the CLA listed above. Also, you need to update the config.yml file, located in gtsam folder too with the new version.

@conan-center-bot

This comment has been minimized.

Sign in to view
@martinvl
Copy link
Contributor Author

@martinvl Please, don't forget to sign the CLA listed above. Also, you need to update the config.yml file, located in gtsam folder too with the new version.

Oops, thanks for the heads up!

Should be fixed now!

@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 43beeb5
gtsam/4.1.1 
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@2/.conan/data/gtsam/4.1.1/_/_/package/4bff4bc354d9735670d1002250b5fd58a220c77f/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan-official-gtsam-targets.cmake
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference/.conan/data/gtsam/4.1.1/_/_/package/b84e5231e4bd678e71a0554c44d1a1687cd2091b/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@3/.conan/data/gtsam/4.1.1/_/_/package/ddab18eb634727be8c799200037bcd992f25d587/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@3/.conan/data/gtsam/4.1.1/_/_/package/9dec127b4672e29980f22a85be11d54bb6d9a7ae/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@3/.conan/data/gtsam/4.1.1/_/_/package/144aefcc4ea948890c2c233d76e5c5ae7b52d18a/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'C:/J/w/prod/BuildSingleReference@4/.conan/data/gtsam/4.1.1/_/_/package/4d3e1610309e36e2b46185c534348a478a3bccfe/'}

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit otherwise this is good

@martinvl @prince-chrismc
Added ref to GTSAM about missing MSVC support
1842dd1 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@martinvl
Copy link
Contributor Author

Awesome, thanks for the added link!

uilianries
uilianries reviewed Jul 19, 2022
View reviewed changes
recipes/gtsam/all/conanfile.py Outdated
@@ -121,6 +121,10 @@ def validate(self):
if self.settings.compiler == "Visual Studio" and tools.Version(self.settings.compiler.version) < 15:
raise ConanInvalidConfiguration ("GTSAM requires MSVC >= 15")

if self.settings.compiler == "Visual Studio" and tools.Version(self.version) >= '4.1' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.settings.compiler == "Visual Studio" and tools.Version(self.version) >= '4.1' \
if is_msvc(self) and tools.Version(self.version) >= '4.1' \

https://docs.conan.io/en/latest/reference/conanfile/tools/microsoft.html#conan-tools-microsoft-is-msvc

Don't forget to add the new import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Pushed a commit which replaces the manual checks with is_msvc() now.

@conan-center-bot
Copy link
Collaborator

All green in build 14 (1ae83b0cb6635b38b54ab52cd62c087639f027b2):

  • gtsam/4.0.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py", line 2, in <module>
    from conans import ConanFile, tools, CMake
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • gtsam/4.1.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py", line 2, in <module>
    from conans import ConanFile, tools, CMake
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

  • gtsam/4.0.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11122/recipes/gtsam/all/conanfile.py", line 2, in <module>
    from conans import ConanFile, tools, CMake
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

@conan-center-bot conan-center-bot merged commit 2083d54 into conan-io:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinvl @conan-center-bot @CLAassistant @uilianries @prince-chrismc