PROD-33: Add civicrm_contribution_recur to LineItem supported entity options #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olayiwola-compucorp ah interesting, so we don't need this anymore compucorp/civicrm-core#78 or even a PR to the core right ? |
Yes, we don't need that anymore |
e4dfe85 to
f8a434b
Compare
|
Given that this passed testing already, and that we will need it for V5, I rebased it with the current master branch (which includes V5 now) and will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM decided to limit the supported entity_table options to some predefined tables as seen in this PR civicrm/civicrm-core#20464, this is now causing error in this extension, because this extension allow users to add LineItems to civicrm_contribution_recur table which is not part of the predefined tables.
Before
After
Technical Details
implement the hook_civicrm_fieldOptions hook to add civicrm_contribution_recur to the LineItem options.