PROD-33: Add civicrm_contribution_recur to LineItem supported entity table options #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olayiwola-compucorp it is better for patches to our civi core fork to be compact, so I would combine these two commits into one, and change the commit short message to explain the "why" not the "what" (e.g PROD-33: Fix adding line items through manage installments screen) and more details can go into the body of the commit message |
… screen This error was fixed by adding civicrm_contribution_recur to CRM_Financial_BAO_FinancialItem and CRM_Price_BAO_LineItem supported LineItem entity tables.
c350832 to
b7a7760
Compare
omarabuhussein
approved these changes
Oct 26, 2021
|
closing this for compucorp/uk.co.compucorp.membershipextras#404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM decided to limit the supported entity_table options to some predefined tables as seen in this PR civicrm#20464, this is now causing error in our https://github.com/compucorp/uk.co.compucorp.membershipextras as we allow users to add LineItems to civicrm_contribution_recur table which is not part of the predefined tables.
This PR is our short-term solution for now.
Before
After