PCHR-2527: Allow custom options to be passed to API calls #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
suggested changes
Aug 22, 2017
| api.getAll(entity, {}); | ||
| }); | ||
|
|
||
| it('default options are still used in the API call', function () { |
There was a problem hiding this comment.
The description of the test should make a sentence with it.
Example: it - "still uses the default options in the API call".
Please check other instances.
deb1990
approved these changes
Aug 22, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently the
api.getAll()function ignores custom options passed as a filter. This PR allows to use custom options in thegetAll()function.Technical Details
Comments
This PR is needed to accomplish #2084.
Please see this PR civicrm/civicrm-core#9844 for the reference to the OR operator support in CiviCRM.