Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20034 - CRM-20034 - Support OR grouping of api get params #9844

Merged
merged 4 commits into from
Feb 19, 2017

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 16, 2017

@colemanw
Copy link
Member Author

@eileenmcnaughton Check this out:

apiexploreror2

@davialexandre
Copy link
Member

davialexandre commented Feb 16, 2017

@colemanw does this support conditions where the same field is used more than once? Like this: (start_date >= '2016-01-01' AND (end_date <= '2016-12-31' OR end_date IS NULL))

@ErichBSchulz
Copy link
Contributor

hey this looks good - where does it fit wrt to the API4 efforts and my suggestion for a nest tree structure of AND|OR|NOT operations?

@colemanw
Copy link
Member Author

@davialexandre the api3 has never supported adding the same param twice. It's on the roadmap for v4, come help us out over on that project! https://github.com/civicrm/api4

@ErichBSchulz this is a stopgap to provide basic OR support for v3. I suspect it will never get any fancier than this. What you're suggesting for v4 sounds good, let's focus our energies there.

@ErichBSchulz
Copy link
Contributor

sweet - ok thanks @colemanw

@colemanw colemanw merged commit 93f1eff into civicrm:master Feb 19, 2017
@colemanw colemanw deleted the CRM-20034 branch February 19, 2017 18:45
@eileenmcnaughton
Copy link
Contributor

looks cool

@colemanw
Copy link
Member Author

Thanks. I'm proud of my css tricks in the api explorer to visualize the and/or groupings.

monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
CRM-20034 - CRM-20034 - Support OR grouping of api get params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants