Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate transmission types #3

Closed
wants to merge 5 commits into from
Closed

Conversation

csouers
Copy link
Contributor

@csouers csouers commented Jul 6, 2019

We have some users with manual trans Hondas that I'd like to work on getting more upstreamable. This is part 1 of that process. I did not include a line for EVs, as that could be considered part of 'automatic'.

Ran make with no errors.

@jyoung8607
Copy link
Contributor

I ask for this PR, or something like it, to be merged in support of the Volkswagen community port. We are asking for it as part of the work in #8:

We already have manual transmission users on the community Volkswagen port, and right now we're having to pretend they're in Drive all the time. We'd like to give them better safety handling, and surely your upload and ingest pipeline will appreciate not being lied to... if nothing else, this will give you a handy marker to identify them and toss the data if you don't want it!

rbiasini added a commit that referenced this pull request Oct 1, 2019
@rbiasini
Copy link
Contributor

rbiasini commented Oct 1, 2019

merged after fixing conflicts. Thanks!
24f6fa7

@rbiasini rbiasini closed this Oct 1, 2019
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this pull request Oct 10, 2019
3d90c78 Fix wrong event enum
f4c92cf add none/invalid usb power mode
12bc189 Add fields and states required for robust Volkswagen safety compliance (#8)
16b5850 let's spell wolkswagen
6243622 Safety cereal (#9)
5cf3c2c change order of UsbPowerMode to preserve panda lib behavior
18a2917 usbPowerMode is more useful to log and it comes from panda
1526784 add ldw to visual hud alerts (#5)
24f6fa7 merge commaai/msgq#3 after fixing conflicts
4d5862c added event about internet connection
ca070f9 Added usbPowerOn to health
e2eaa76 add HW type for UNO
e528a20 Read RPM from fan connected to Panda
8472175 Added invalidGiraffeToyota event
71be970 placeholders for mazda, nissan and vw safety models

git-subtree-dir: cereal
git-subtree-split: 3d90c78
krkeegan pushed a commit to krkeegan/cereal that referenced this pull request Oct 20, 2021
Kirito3481 pushed a commit to Kirito3481/msgq that referenced this pull request Dec 4, 2024
* pre-commit: autoupdate hooks (commaai#532)

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Update README.md (commaai#533)

* pre-commit: autoupdate hooks (commaai#535)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* services: capitalize constant service list (commaai#534)

* rename services

* keep more unique name

* type this

* Bump pandaStates to 10hz (commaai#536)

* 10 Hz

* constant

* fix

* revert

* fix peripheralState freq

* revert peripheral

* Bringing sunnypilot

* Refactor service list and deprecate certain fields

Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance.

* pre-commit: autoupdate hooks (commaai#538)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Added reserved fields for body controls (commaai#537)

* Added bodyReserved0-2 text fields

* Added bodyReserved0 to services list

* add more bodyReserved to servcies py

* bodyReserved -> customReservedText

* :Text -> :Data

---------

Co-authored-by: Kacper Rączy <gfw.kra@gmail.com>

* zmq: assert the same PID (commaai#540)

Enforce the same PID in ZMQ pub sockets

* pre-commit: autoupdate hooks (commaai#541)

Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>

* Bringing sunnypilot

* Refactor service list and deprecate certain fields

Refactored service list naming convention in messaging/init.py and services.py for consistency, changing `service_list` to `SERVICE_LIST`. Additionally, fields as `laneWidth`, `lProb`, `rProb`, `dProb` in `LateralPlan` struct and `brakeLights` in `CarEvent.EventName` have been marked as DEPRECATED as part of an ongoing effort for codebase clean-up. Changes also include updating the frequency of `pandaStates` service and commenting out a debug statement in msgq.cc, enhancing overall system performance.

* Bringing sunnypilot's cereal changes aligned

* Converging cereal changes

* accidentally duplicated some literals

* Update log.capnp

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
Co-authored-by: JJ <103335846+computerscienceiscool@users.noreply.github.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Miguel Fernandez <miguel.fernandez@cimpress.com>
Co-authored-by: Mitchell Goff <mitchellgoffpc@gmail.com>
Co-authored-by: Kacper Rączy <gfw.kra@gmail.com>
Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
alienware-sa pushed a commit to alienware-sa/FPilot that referenced this pull request Mar 4, 2025
3d90c7877 Fix wrong event enum
f4c92cf4e add none/invalid usb power mode
12bc18965 Add fields and states required for robust Volkswagen safety compliance (#8)
16b5850f1 let's spell wolkswagen
6243622e6 Safety cereal (#9)
5cf3c2c76 change order of UsbPowerMode to preserve panda lib behavior
18a291779 usbPowerMode is more useful to log and it comes from panda
152678429 add ldw to visual hud alerts (#5)
24f6fa78c merge commaai/msgq#3 after fixing conflicts
4d5862c54 added event about internet connection
ca070f9fd Added usbPowerOn to health
e2eaa762b add HW type for UNO
e528a2041 Read RPM from fan connected to Panda
8472175d6 Added invalidGiraffeToyota event
71be97053 placeholders for mazda, nissan and vw safety models

git-subtree-dir: cereal
git-subtree-split: 3d90c7877f9ef9269735b074c0cb23f5eb6d2b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants