Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to add UTF-8 BOM #121

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Add option to add UTF-8 BOM #121

merged 1 commit into from
Jun 17, 2020

Conversation

eitoball
Copy link
Contributor

Originally #103

  • rename add_bom to with_bom
  • add spec for with_bom
  • change to use expect syntax

Closes #103 #116

@eitoball eitoball self-assigned this Jun 16, 2020
@eitoball eitoball marked this pull request as ready for review June 16, 2020 23:45
@eitoball eitoball force-pushed the add-utf-8-bom branch 3 times, most recently from af00406 to ebc4768 Compare June 17, 2020 03:26
@DannyBen @eitoball
add option to prepend utf8 bom
1a8c50b 
- rename add_bom to with_bom
- add spec for with_bom
- change to use expect syntax
@eitoball eitoball merged commit 4b3019a into master Jun 17, 2020
@eitoball eitoball deleted the add-utf-8-bom branch June 17, 2020 13:20
@eitoball eitoball mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eitoball eitoball

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitoball @DannyBen