Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to add UTF-8 BOM #103

Closed
wants to merge 4 commits into from
Closed

Add option to add UTF-8 BOM #103

wants to merge 4 commits into from

Conversation

DannyBen
Copy link
Contributor

This PR adds the with_bom option.

  • I added a spec as well, near where you test the other options, but was unable to see it run due to the need for a dummy app and all. perhaps someone who already has a testing environment set up can make sure it works.
  • I had to update the sqlite3 gem version. The old one just refused to be built, probably due to my ruby version.

@eitoball eitoball mentioned this pull request Jun 16, 2020
Merged
@DannyBen DannyBen deleted the bom branch June 17, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DannyBen