-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mill init
from an existing Maven project (1500USD Bounty)
#3449
Comments
mill init
from a Maven projectmill init
from a Maven project (1500USD Bounty)
mill init
from a Maven project (1500USD Bounty)mill init
from a SBT project (1500USD Bounty)
mill init
from a SBT project (1500USD Bounty)mill init
from a Maven project (1500USD Bounty)
mill init
from a Maven project (1500USD Bounty)mill init
from an existing Maven project (1500USD Bounty)
Is there any infrastructure for this already? For example, does |
@arturaz mill/main/src/mill/main/MainModule.scala Line 403 in 7732b0f
It should be pretty easy to add logic to check if there's an existing |
I'll try to implement this :) |
@arturaz go for it! |
@arturaz Is this completed? If not do you mind if I give this a try 24 hours from now? |
I am working on it right now (fell ill with COVID after starting it). Could you give me a couple of days to finish it? 🙂
…---- On Mon, 23 Sep 2024 03:29:37 +0300 ***@***.*** wrote ----
@arturaz Is this completed? If not do you mind if I give this a try 24 hours from now?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
@arturaz Would you like some help with completing it? |
I'm not sure how that'd work, at least right now, but I will keep that in mind! |
@arturaz Bounty percentages seem like a reasonable option if you're interested in receiving help & sharing some bounty percentage. |
Hey @llvee. I think you should take over this. I've pushed what I've done to arturaz@3bcf834 , feel free to use any or none of it. I've hit a bump while implementing BOM file support and thinking on how to translate that to mill when Maven allows property references to be used in any part of the artifact. And then life hit me and now it seems I won't have time for at least 3 weeks. I've used these repos as the target for conversion: Cheers! |
Yes depending on Scalalib is fine. We can reorganize the module
dependencies inside Mill as necessary.
But we should not need fancy build DSLs. We just need to generated source
code as strings. Helper methods are fine, but Scala already does a decent
job at mangling strings. I don't want this to be overengineered
…On Sat, 12 Oct 2024 at 3:26 PM, Ajay Chandran ***@***.***> wrote:
@lihaoyi <https://github.com/lihaoyi>
Would it be okay if mill.init package depended on mill.scalalib?
This allows for patterns like
// Build DSL
// usage: extends[mill.Module]
def `extends`[T](implicit T: ClassTag[T]): Build =
`extends`(T.runtimeClass.getCanonicalName)
// usage: extends("mill.Module")
def `extends`(supertype: String): Build =
???
—
Reply to this email directly, view it on GitHub
<#3449 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5HBDBSTOLUQZCF5DPHC3LZ3EPQ7AVCNFSM6AAAAABNRLVUQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU3DKMZUGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
From the maintainer Li Haoyi: I'm putting a 1500USD bounty on this issue, payable by bank transfer on a merged PR implementing this.
We should be able to run
./mill init
to do a best effort conversion of an existing Maven project to Mill:build.mill
containing aMavenModule
for the rootpom.xml
, thepackage.mill
for any subfolderpom.xml
sivyDeps
moduleDeps
javacOptions
PublishModule
with relevant metadataSuch a conversion will never be 100%, but if we can automate 80% of the conversion that will already be a huge help for people migrating to Mill or even just trying it out
Some prior art that can be used as reference:
The text was updated successfully, but these errors were encountered: