Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: keychain created by keychain initialize is inaccessible by Xcode #129

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Jul 2, 2021

The default keychain path chage from PR #126 broke iOS builds executed with xcode-project build-ipa as Xcode is unable to access secrets from the keychain created in ~/Library/Keychains/<keychain-name>.keychain-db. Patch this by creating keychains in ~/Library/codemagic-cli-tools/keychains by default using keychain initialize.

@priitlatt priitlatt added the bug Something isn't working label Jul 2, 2021
@priitlatt priitlatt changed the title Bugfix: keychain created by keychain initialized is inaccessible by Xcode Bugfix: keychain created by keychain initialize is inaccessible by Xcode Jul 2, 2021
@priitlatt priitlatt marked this pull request as ready for review July 2, 2021 11:02
@artemii-yanushevskyi
Copy link
Contributor

Just to confirm, how could we be sure that ~/Library/codemagic-cli-tools/keychains will be accessible by Xcode?

@priitlatt
Copy link
Contributor Author

#129 (comment)
@artemii-yanushevskyi, I tested it properly now 😉

@priitlatt priitlatt merged commit b5b810a into master Jul 2, 2021
@priitlatt priitlatt deleted the bugfix/keychain-inaccessible-by-xcode branch July 2, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants