Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create keychains to temporary directory by default #126

Closed
craastad opened this issue Jun 28, 2021 · 2 comments · Fixed by #125
Closed

Do not create keychains to temporary directory by default #126

craastad opened this issue Jun 28, 2021 · 2 comments · Fixed by #125
Labels
bug Something isn't working

Comments

@craastad
Copy link
Contributor

craastad commented Jun 28, 2021

Naively using CLI tools can have undesirable consequences for the mac keychain. We should work to avoid these for default usages.

My mistake was fixed with keychain make-default ~/Library/Keychains/login.keychain-db

I think that maybe we shouldn’t generate the keychain into $TMPDIR directory by default. when default keychain is not restored back to the system default login keychain and a reboot is performed, then the previous default keychain goes missing and system OS finds itself in a odd situation where default keychain is set, but it doesn’t exist.

The code changes are drafted in: https://github.com/codemagic-ci-cd/cli-tools/pull/125/files

@craastad craastad added the bug Something isn't working label Jun 28, 2021
@priitlatt priitlatt linked a pull request Jun 28, 2021 that will close this issue
@priitlatt
Copy link
Contributor

Currently keychain initialize indeed creates new keychain into a temporary directory by default. This can cause issues if system is rebooted and login keychain is not set to default beforehand.

@priitlatt
Copy link
Contributor

Fix was released in version 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants