-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old version warning #86
base: master
Are you sure you want to change the base?
Conversation
bcb9a66
to
ae29839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use comparing instead of compare in the commit description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think the code you have written does not comply to the set style. Did you run coala
locally before pushing? Please see the logs for the failing ci tests.
@kriti21 I've modified |
I think the problem starts here. |
Oh okay! My bad ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits.
@ankurg22 I have done two changes that are not related to each others, hence the two commits. |
I think they are related to each other. They both solve the same issue after-all. You should squash your commits into one. @Kagamihime |
@kriti21 No, they are not related: the first one is related to the suggestion in the issue |
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
CircleCI is still failing? |
ya, I've forced in the other two pending PRs as they were really basic. |
I understand. I am not active because I am quite busy for now, but I will remain available if something needs to be done here ;) |
Closes #48