Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing due to MarkdownBear deleting all markdown content #81

Open
jayvdb opened this issue Nov 3, 2017 · 7 comments
Open

Comments

@jayvdb
Copy link
Member

jayvdb commented Nov 3, 2017

https://circleci.com/gh/jayvdb/coala-atom/16

@jayvdb
Copy link
Member Author

jayvdb commented Nov 3, 2017

This is odd.
here is my patch: jayvdb@02229a92a883

remark is definitely there.

It is running

[DEBUG][09:45:50] Running 'remark /home/ubuntu/coala-atom/README.md --no-color --quiet --setting "incrementListMarker": true, "rule": "", "ruleRepetition": 3, "fence": "`", "entities": false, "fences": true, "ruleSpaces": false, "listItemIndent": "1", "setext": false, "emphasis": "", "looseTable": false, "bullet": "-", "strong": "*", "closeAtx": false, "spacedTable": true --use lint="codeBlockStyle": "consistent", "noEmptyURL": true, "noShortcutReferenceLink": true, "noHeadingPunctuation": ".,;:!?", "noUndefinedReferences": true, "headingIncrement": false, "maximumHeadingLength": 60, "noDuplicateDefinitions": true, "noHTML": true, "noDuplicateHeadings": true, "finalDefinition": true, "blockquoteIndentation": 2, "checkboxContentIndent": true, "firstHeadingLevel": null, "noTabs": true, "noDuplicateHeadingsInSection": true, "noShortcutReferenceImage": true, "noUnusedDefinitions": true, "noFileNameIrregularCharacters": "\.a-zA-Z0-9-_"'

Unfortunately, I've got to go. Unassigning in case someone else knows the solution.

@blazeu
Copy link
Member

blazeu commented Nov 3, 2017

I encountered this issue while adding coala to my project. Installing remark package explicitly, not just remark-cli and remark-lint (and maybe pin the exact version that I used) seems to solve the problem.

https://github.com/blazeu/atom-browsersync/blob/coala/.travis.yml#L14 ~> https://travis-ci.org/blazeu/atom-browsersync#L1047

remark version 8 is not explicitly supported by coala, but it works well, seems like it needs updating in coala-bears repo.

@blazeu
Copy link
Member

blazeu commented Nov 4, 2017

I've found the real problem.

remark won't run on older version of nodejs in shipped with circleci by default. See my build

Using node v6.11.5 the build ran successfully.

blazeu added a commit to blazeu/coala-atom that referenced this issue Nov 4, 2017
`remark` which is used by MarkdownBear won't run under default nodejs
version in circleci.

Fixes coala#81
blazeu added a commit to blazeu/coala-atom that referenced this issue Nov 4, 2017
`remark` which is used by MarkdownBear won't run under default nodejs
version in circleci.

Fixes coala#81
@rultor rultor closed this as completed in #83 Nov 5, 2017
@jayvdb jayvdb reopened this Nov 5, 2017
@jayvdb jayvdb changed the title Build is failing Build is failing due to MarkdownBear deleting all markdown content Dec 13, 2017
@jayvdb
Copy link
Member Author

jayvdb commented Dec 13, 2017

I've improved the title of this issue so people know what it is about.

@yashovardhan
Copy link
Member

we have to change the whole README.md to get this rectified?

@blazeu
Copy link
Member

blazeu commented Dec 13, 2017

No.

We have to remove the whole README.md to get this rectified. There's no other option, and by that it means we cannot have any markdown. This is a definite bug on MarkdownBear coala/coala-bears#2131

@yashovardhan
Copy link
Member

making a new one will the option then...

that's what I am saying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants