Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo's in PHPDoc #15

Merged
merged 1 commit into from
Nov 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ empty array without processing any jobs.
The `$handler` parameter must be a valid callable that accepts your job
parameters, invokes the appropriate operation and returns a Promise as a
placeholder for its future result. If the given argument is not a valid
callable, this method will reject with an `InvalidArgumentExceptionn`
callable, this method will reject with an `InvalidArgumentException`
without processing any jobs.

```php
Expand Down
6 changes: 3 additions & 3 deletions src/Queue.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* immediately. If you keep adding new jobs to the queue and its concurrency limit
* is reached, it will not start a new operation and instead queue this for future
* execution. Once one of the pending operations complete, it will pick the next
* job from the qeueue and execute this operation.
* job from the queue and execute this operation.
*/
class Queue implements \Countable
{
Expand Down Expand Up @@ -84,7 +84,7 @@ class Queue implements \Countable
* The `$handler` parameter must be a valid callable that accepts your job
* parameters, invokes the appropriate operation and returns a Promise as a
* placeholder for its future result. If the given argument is not a valid
* callable, this method will reject with an `InvalidArgumentExceptionn`
* callable, this method will reject with an `InvalidArgumentException`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the README.md has the exact same typo, can you amend this? :shipit:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, my git skills are still too poor to do a real "amend", so you might need to squash he commits into one....

* without processing any jobs.
*
* ```php
Expand Down Expand Up @@ -237,7 +237,7 @@ public function __invoke()
);
}

// we're currently above concurreny limit, make sure we do not exceed maximum queue limit
// we're currently above concurrency limit, make sure we do not exceed maximum queue limit
if ($this->limit !== null && $this->count() >= $this->limit) {
return Promise\reject(new \OverflowException('Maximum queue limit of ' . $this->limit . ' exceeded'));
}
Expand Down