Fix small typo's in PHPDoc #15
Conversation
| @@ -84,7 +84,7 @@ class Queue implements \Countable | |||
| * The `$handler` parameter must be a valid callable that accepts your job | |||
| * parameters, invokes the appropriate operation and returns a Promise as a | |||
| * placeholder for its future result. If the given argument is not a valid | |||
| * callable, this method will reject with an `InvalidArgumentExceptionn` | |||
| * callable, this method will reject with an `InvalidArgumentException` | |||
There was a problem hiding this comment.
LGTM, the README.md has the exact same typo, can you amend this? 
There was a problem hiding this comment.
Done, my git skills are still too poor to do a real "amend", so you might need to squash he commits into one....
There was a problem hiding this comment.
@holtkamp Thank you for the update, the changes LGTM 👍
Can you squash your two commits into a single one?
Squash commits into one with Git
Step 1: choose your starting commit. The first thing to do is to invoke git to start an interactive rebase session: git rebase --interactive HEAD~[N] ...
Step 2: picking and squashing. At this point your editor of choice will pop up, showing the list of commits you want to merge. ...
Step 3: Create the new commit.
– https://www.internalpointers.com/post/squash-commits-into-one-git
|
Github also offers this "squash and merge" at the tip of a button, right? My experience is that I will fail, retry, fail again and then succeed, which will take another hour of my life... Happy to invest it, but this is a really tiny PR 👼 |
|
@holtkamp I've reset the branch and force-pushed for you 👍 But you're missing out, you may still want to take a look at interactive rebasing and amending changes for the next time :-) For the record: I've disabled GitHub's squash function on all my repos because it creates a new squashed commit and leaves PRs as stale branches, meh. Providing proper PRs is much cleaner and allows for a simpler git history IMHO. Either way, now let's get this in |
sure, believe me I did, I tried and based on your advise will try again
Ah, ok, I did not know that / see that, excusez-moi! |
|
@holtkamp No worries, it's a very nuanced difference and your contribution is much appreciated either way! 💯 |
No description provided.