Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default values, typo #17

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix default values, typo #17

merged 2 commits into from
Dec 1, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Dec 1, 2021

Special Note

This PR is a duplicate of #10, which was authored by @lgallard. See that PR for details. This PR replaces #10 due to administrative/permissions issues only. Supersedes and closes #10.

what

  • Change default values to include_map and exclude_map attributes
  • Fix typo: shiled -> shield

why

  • To avoid different types in Terraform conditionals
  • Fix typo in naming resources.

references

lgallard and others added 2 commits November 30, 2021 23:30
# Conflicts:
#	README.md
#	README.yaml
#	docs/terraform.md
#	examples/complete/outputs.tf
#	main.tf
@Nuru Nuru requested review from a team as code owners December 1, 2021 07:51
@Nuru Nuru requested review from adamcrews and milldr December 1, 2021 07:51
@Nuru Nuru mentioned this pull request Dec 1, 2021
@Nuru Nuru merged commit 1122c00 into master Dec 1, 2021
@mergify mergify bot deleted the binbashar-fix/default-values branch December 1, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in variable and resource name
2 participants