Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in variable and resource name #15

Closed
LuigiClemente-Awin opened this issue Nov 19, 2021 · 1 comment · Fixed by #17
Closed

Typo in variable and resource name #15

LuigiClemente-Awin opened this issue Nov 19, 2021 · 1 comment · Fixed by #17
Labels
bug 🐛 An issue with the system

Comments

@LuigiClemente-Awin
Copy link

I suspect you used the word "shiled_advanced" instead of "shield_advanced" everywhere in the code and in the variables.
No typo check at all?

Best,

Luigi
@LuigiClemente-Awin LuigiClemente-Awin added the bug 🐛 An issue with the system label Nov 19, 2021
@nitrocode
Copy link
Member

@LuigiClemente-Awin nice catch

terraform-aws-firewall-manager/variables.tf

Line 137 in 0460e1f

variable "shiled_advanced_policies" {

please submit a pull request and we'll review it

@nitrocode nitrocode mentioned this issue Nov 25, 2021
Closed
@Nuru Nuru mentioned this issue Dec 1, 2021
Merged
@Nuru Nuru closed this as completed in #17 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
2 participants
@nitrocode @LuigiClemente-Awin