Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.14 upgrade #20

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Terraform 0.14 upgrade #20

merged 2 commits into from
Jan 7, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Dec 21, 2020 •
edited
Loading

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

  • Support Terraform 0.14

supersedes and closes #18

@maximmi maximmi requested review from Gowiem and aknysh December 21, 2020 05:49
@maximmi maximmi requested a review from a team as a code owner December 21, 2020 05:49
@maximmi
Copy link
Contributor Author

maximmi commented Dec 21, 2020

/test all

1 similar comment
@maximmi
Copy link
Contributor Author

maximmi commented Dec 21, 2020

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Dec 21, 2020

/test all

2 similar comments
@goruha
Copy link
Member

goruha commented Dec 21, 2020

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Dec 21, 2020

/test all

@viyullas
Copy link

would be great to have this merged...

@anarsen anarsen mentioned this pull request Jan 6, 2021
Closed
danjbh
danjbh approved these changes Jan 6, 2021
View reviewed changes
Copy link

@danjbh danjbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximmi maximmi merged commit b74c92a into master Jan 7, 2021
@maximmi maximmi deleted the terraform-0.14-upgrade branch January 7, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjbh danjbh danjbh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximmi @goruha @viyullas @danjbh