Relax required Terraform version to >= 0.12.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RothAndrew
previously approved these changes
Dec 3, 2020
|
Thanks. Note that this PR needs further version bump on module dependencies, namely due to this: cloudposse/terraform-aws-route53-cluster-hostname#29 Marking this as draft to avoid accidental merging. |
|
/test all |
|
/rebuild-readme |
This enables use of Terraform 0.14 which was recently released. I wasn't sure whether you'd then like a `>= 0.12.0, < 0.15` constraint instead. This is taken from https://github.com/cloudposse/terraform-aws-acm-request-certificate/blob/master/versions.tf.
|
@RothAndrew Should be ready now. I bumped the version on the dependency towards |
|
/test all |
RothAndrew
approved these changes
Dec 7, 2020
|
/test all |
|
@RothAndrew Is there anything missing before this can be merged? I noticed the checks are failing, but the error isn't clear to me. |
Merged
|
Closed in favor of #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables use of Terraform 0.14 which was recently released.
Requires this to be merged and released first: cloudposse/terraform-aws-route53-cluster-hostname#29