Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: upgrade to ginkgo v2 #22

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Feat: upgrade to ginkgo v2 #22

merged 2 commits into from
Jun 15, 2022

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jun 15, 2022

Description

Upgrade to ginkgo v2.

Also:

  • Sets min go version to go1.18.
  • Bumps some dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@ctlong
Regenerate go.mod and vendor again
7b9dd93 
Also sets min go version to go1.18.
@ctlong ctlong force-pushed the feat/ginkgo-v2 branch 2 times, most recently from f47c20a to ee70cc6 Compare June 15, 2022 03:05
@ctlong
Upgrade to ginkgo v2
a24fb80 
* Use `github.com/onsi/ginkgo/v2` package everywhere.
* Replace deprecated `GinkgoParallelNode` with `GinkgoParallelProcess`.
* Update `Go / test` workflow to use ginkgo v2 CLI and flags.
  https://onsi.github.io/ginkgo/#recommended-continuous-integration-configuration.
@ctlong ctlong marked this pull request as ready for review June 15, 2022 03:08
@ctlong ctlong mentioned this pull request Jun 15, 2022
Merged
10 tasks
@ctlong ctlong requested review from acrmp, Benjamintf1 and mkocher June 15, 2022 03:15
mkocher
mkocher approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@mkocher mkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctlong ctlong merged commit 47e0e4f into main Jun 15, 2022
@ctlong ctlong deleted the feat/ginkgo-v2 branch June 15, 2022 17:54
@ctlong ctlong mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkocher mkocher mkocher approved these changes

@acrmp acrmp Awaiting requested review from acrmp

@Benjamintf1 Benjamintf1 Awaiting requested review from Benjamintf1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctlong @mkocher