Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARP WG Logging & Metrics: add ctlong #318

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jun 23, 2022

No description provided.

@ctlong
Copy link
Member Author

ctlong commented Jun 23, 2022

Some of the significant PRs I've authored in this area:

  1. Fix v2 egress server test loggregator-release#421
  2. Fix go test errors statsd-injector-release#10
  3. Bump go-loggregator to v8 statsd-injector-release#11
  4. Chore: Update docs to not include info about a standalone CLI log-cache-cli#67
  5. Remove unused functions pivotal-cf/metric-registrar-cli#12
  6. Separate Log Cache in diagrams docs-loggregator#58
  7. Feat: reorganize packages log-cache-cli#69
  8. Upgrade ginkgo to v2 pivotal-cf/metric-registrar-cli#13
  9. Feat: release workflow log-cache-cli#71
  10. Update: README.md syslog-release#69
  11. Feat: regenerate protobuf sonde-go#11
  12. Fix: rename loggregator agent code loggregator-agent-release#87
  13. Update: github.com/onsi/ginkgo/v2 log-cache-cli#76
  14. Update: README.md go-metric-registry#8
  15. Allow log-cache-cli to have wiki pages #241
  16. Update: add golangci configuration and workflow for better go linting log-cache-cli#78
  17. Feat: prom scraper log on recovery loggregator-agent-release#91
  18. Update: tailOptions should use the source struct log-cache-cli#80
  19. Remove: git-hooks loggregator-release#439
  20. golangci-lint: ignore specific instance of G402 rather than all instances log-cache-cli#82
  21. Feat: workflows statsd-injector-release#14
  22. Feat: GitHub workflows metrics-discovery-release#26
  23. Feat: workflows loggregator-release#440
  24. Feat: GitHub workflows loggregator-agent-release#99
  25. Feat/workflows log-cache-release#63
  26. Feat: GitHub workflows go-pubsub#6
  27. Feat: go modularize go-orchestrator#4
  28. Update go workflows with golangci-lint go-metric-registry#11
  29. Feat: GitHub workflows go-log-cache#36
  30. Feat: GitHub workflows go-envstruct#19
  31. Initialize go module in repo go-batching#3
  32. Initialize go module in this repo dropsonde#24
  33. Fix: golangci-lint warnings system-metrics-scraper-release#17
  34. Feat: regenerate helheim mocks statsd-injector-release#18
  35. Feat: separate out example app into its own module statsd-injector-release#19
  36. Fix: deprecated gRPC functions statsd-injector-release#20
  37. Feat: upgrade to ginkgo v2 system-metrics-scraper-release#22
  38. Feat: upgrade to go-loggregator v8 system-metrics-scraper-release#23
  39. Feat: upgrade to ginkgo v2 metrics-discovery-release#31
  40. Feat: upgrade to ginkgo v2 statsd-injector-release#22
  41. Fix: race conditions in tests go-loggregator#80

I can go hunt down more + add some issues if needed :).

@ctlong
Copy link
Member Author

ctlong commented Jun 23, 2022

cc @ameowlia (WG lead) @acrmp @Benjamintf1 (approvers in this area) for review

@ameowlia
Copy link
Member

📝 According to the docs, to be nominated to approver you must be: "Nominated by a WG lead (with no objections from other leads)."

✨ As the WG lead for this area I heartily endorse this nomination. Carson has been a great addition to our WG and one of our most active members. I am very excited to welcome him as our first non-bootstrapped WG approver.

👉 Tagging other leads. Please comment if you have any objection. If there are no objections within 1 week I will merge this PR. @cloudfoundry/toc, @cloudfoundry/working-group-leads

@emalm emalm added the wg label Jun 28, 2022
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ameowlia ameowlia merged commit fec377d into cloudfoundry:main Jun 30, 2022
@ameowlia
Copy link
Member

Congrats @ctlong! Welcome!

@ctlong ctlong deleted the ctlong-promote-to-approver branch June 30, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants