Consume per request metrics reporting config #198
Conversation
This change addresses issue cloudfoundry#159. It exposes the new gorouter config properties per_request_metrics_reporting, send_http_start_stop_server_event and send_http_start_stop_client_event in the gorouter job spec. This properties can be used to reduce the number of metric events the gorouter sends per request.
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
|
|
@stefanlay can you add which metrics specifically will be turned on/off in the description? Other than that, lgtm. |
|
Hi, when will this be released? :) |
|
😭 When I get our red pipelines green. Failures are unrelated to this change. Please keep pinging about it. Squeaky wheel gets the grease and all that. |
|
Pinging again as requested 😀 Thanks for your efforts here! |
|
The pipeline is green as of yesterday and all the new commits (including yours) should be going through today. Expect good news soon! Thank you for your patience! |
|
Hi all, I'm also interested to see this fix being available - any timelines of this released to the customers? |
|
This was released on March 19 in 0.213.0!! 🎉 🐱 🍰 🎈 |
This change addresses Gorouter emits way too many metrics (metric frequency proportional to request frequency) gorouter#159 and makes new properties from the gorouter consumable.
See instructions and explanation in related PR for gorouter: cloudfoundry/gorouter#275
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run all the unit tests using
scripts/run-unit-tests-in-docker