Configure gorouter keep alive probe interval #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cloudfoundry/gorouter#258 we customised and made configurable the endpoint_keep_alive_probe_interval property in gorouter. This commit allows the user to configure the endpoint_keep_alive_probe_interval using the router.keep_alive_probe_interval property, and adds a default so documentation is clear. In order to confirm that my logic was correct I added some tests Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/169406312 The labels on this github issue will be updated when the story is started. |
|
@tlwr Thanks for contributing!! |
stefanlay
added a commit
to stefanlay/routing-release
that referenced
this pull request
Mar 3, 2021
This change addresses issue cloudfoundry#159. It exposes the new gorouter config properties per_request_metrics_reporting, send_http_start_stop_server_event and send_http_start_stop_client_event in the gorouter job spec. This properties can be used to reduce the number of metric events the gorouter sends per request.
ameowlia
pushed a commit
that referenced
this pull request
Mar 4, 2021
This change addresses issue #159. It exposes the new gorouter config properties per_request_metrics_reporting, send_http_start_stop_server_event and send_http_start_stop_client_event in the gorouter job spec. This properties can be used to reduce the number of metric events the gorouter sends per request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
In cloudfoundry/gorouter#258 we customised and made configurable the endpoint_keep_alive_probe_interval property in gorouter.
This commit allows the user to configure the
endpoint_keep_alive_probe_intervalusing therouter.keep_alive_probe_intervalproperty, and adds a default so documentation is clear.In order to confirm that my template logic was correct I added some tests.
I am on my work Macbook Air, so I have not run all the tests, I have only run
bundle exec rspecas my changes is limited to the gorouter job spec.Mentions
@KauzClay @angelachin are the two people mentioned in cloudfoundry/gorouter#258
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run all the unit tests using
scripts/run-unit-testsI have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
I have run CF Acceptance Tests on bosh lite