Update user-provided service tags #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#61861194]
- Plan validation in separate function [#72117050]
- Fixing a bug where passing arbitrary params without a plan change would result in making no changes [#96250704]
- Add ui_helpers/tags_parser.go [#72117050]
[#72117050]
- Improve params example to resemble a bind [#96320118] and [#72117050]
Conflicts: cf/commands/service/update_service.go cf/i18n/resources/de_DE.all.json cf/i18n/resources/en_US.all.json cf/i18n/resources/es_ES.all.json cf/i18n/resources/fr_FR.all.json cf/i18n/resources/it_IT.all.json cf/i18n/resources/ja_JA.all.json cf/i18n/resources/pt_BR.all.json cf/i18n/resources/zh_Hans.all.json cf/i18n/resources/zh_Hant.all.json
|
Hey rmasand! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/96505298. |
| @@ -203,7 +203,7 @@ var _ = Describe("Services Repo", func() { | |||
| Response: testnet.TestResponse{Status: http.StatusCreated}, | |||
| })) | |||
|
|
|||
| err := repo.CreateServiceInstance("instance-name", "plan-guid", nil) | |||
| err := repo.CreateServiceInstance("instance-name", "plan-guid", nil, nil) | |||
There was a problem hiding this comment.
I kind of hate seeing these nils all over the place when we could use empty string array... But eh, that's just me.
Though hopefully we are testing for case when tags is empty array vs nil...
|
Thanks a bunch for fixing this. Merged. |
jberkhahn
added a commit
that referenced
this pull request
Jun 9, 2015
Update user-provided service tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to add the "-t" flag for update-service. We've also fixed that command so users can update instance tags and/or arbitrary params without supplying an updated plan. Some cleanup of translated strings is included as well.
https://www.pivotaltracker.com/story/show/72117050