Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional tags to create-service command #463

Merged
merged 2 commits into from
Jun 10, 2015
Merged

Add optional tags to create-service command #463

merged 2 commits into from
Jun 10, 2015

Conversation

Gerg
Copy link
Member

@Gerg Gerg commented May 28, 2015

@cfdreddbot
Copy link

Hey Gerg!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/95663206.

@jberkhahn
Copy link
Contributor

Hey @Gerg
It looks like we've updated the translation files for this since you submitted the PR. Could you rebase on master to fix the merge conflicts?
Other than that this looks good.

@mmb mmb force-pushed the cli_user_can_provide_tags branch from dd5c171 to b06a770 Compare June 5, 2015 16:39
@rainmaker
Copy link
Contributor

We've done a rebase, should be an easier merge now.

@mmb mmb force-pushed the cli_user_can_provide_tags branch from b06a770 to b964b73 Compare June 5, 2015 16:42
maximilien
maximilien reviewed Jun 5, 2015
View reviewed changes
cf/i18n/resources/fr_FR.all.json
@@ -4540,6 +4540,11 @@
"modified": false
},
{
"id": "User provided tags",
"translation": "User provided tags",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation: "Étiquettes fourni par l'utilisateur"

@rainmaker rainmaker force-pushed the cli_user_can_provide_tags branch from 9b23431 to 42fd356 Compare June 8, 2015 21:51
rainmaker added 2 commits June 10, 2015 11:46
@rainmaker
Split create-service usage for easier translation
38c010d 
[#61861194]
@rainmaker @Gerg
Fix indentation in create-service help text
870ead8 
- And rearrange translation files to appease i18n4go
@rainmaker rainmaker force-pushed the cli_user_can_provide_tags branch from 86d57e0 to 870ead8 Compare June 10, 2015 18:54
@rainmaker
Copy link
Contributor

Because #474 was merged already, this PR now just includes some formatting changes to the help text and translations.

@jberkhahn
Copy link
Contributor

Nice! Merged.

jberkhahn added a commit that referenced this pull request Jun 10, 2015
@jberkhahn
Merge pull request #463 from cloudfoundry/cli_user_can_provide_tags
92ecfcd 
Add optional tags to create-service command
@jberkhahn jberkhahn merged commit 92ecfcd into master Jun 10, 2015
@Gerg Gerg deleted the cli_user_can_provide_tags branch June 11, 2015 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gerg @cfdreddbot @cf-gitbot @jberkhahn @rainmaker @maximilien