-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cf revisions
no longer reports EXPERIMENTAL notice [main]
#3062
cf revisions
no longer reports EXPERIMENTAL notice [main]
#3062
Conversation
cf revisions
no longer reports EXPERIMENTAL notice [main]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f6db66d
to
4d9afeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the test was there to ensure that the message was present I do not think these tests make sense anymore.
If you come back to the code and see this test, it is strange 😄
4d9afeb
to
03fd9b0
Compare
|
03fd9b0
to
411bfc6
Compare
411bfc6
to
6149404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ndry#3062) * `cf revisions` no longer reports EXPERIMENTAL notice * Move `revision` and `revisions` commands into APPS section of help * Remove negative assertions for revision commands' experimental status * Restore "revision" command to experimental status * `cf rollback` no longer reports EXPERIMENTAL status * Remove superfluous newline Co-authored-by: Nicolas Bender <nicolas.bender@sap.com>
Description of the Change
This commit changes the
cf revision
andcf revisions
commands to no longer print a notice that the command is experimental.Why Is This PR Valuable?
The
cf revision
andcf revisions
commands were introduced over 4 years ago and are no longer experimental.Applicable Issues
n/a
How Urgent Is The Change?
Not urgent.
Other Relevant Parties
None
Related PRs
cf revisions
no longer reports EXPERIMENTAL notice [v7] #3060 - v7cf revisions
no longer reports EXPERIMENTAL notice [v8] #3061 - v8cf revisions
no longer reports EXPERIMENTAL notice [main] #3062 - main (this PR)