-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cf revisions
no longer reports EXPERIMENTAL notice [v7]
#3060
cf revisions
no longer reports EXPERIMENTAL notice [v7]
#3060
Conversation
f3ba47c
to
c77a48b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question [blocking]: I'm questioning if these types of changes belong to V7, as V7 is at the end of its lifecycle. My understanding is that V7 receives security and bug fixes, while behavior changes belong to V8 and main (future V9).
Since it is removing the Experimental warning, I am not sure we can consider this a new feature, it is more housekeeping now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the test was there to ensure that the message was present I do not think these tests make sense anymore.
If you come back to the code and see this test, it is strange 😄
@joaopapereira I did not say anything about a new feature. Removing |
c77a48b
to
a115b7a
Compare
|
a115b7a
to
276007c
Compare
Updated PR to incorporate @Samze's feedback on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the Change
This commit changes the
cf revision
andcf revisions
commands to no longer print a notice that the command is experimental.Why Is This PR Valuable?
The
cf revision
andcf revisions
commands were introduced over 4 years ago and are no longer experimental.Applicable Issues
n/a
How Urgent Is The Change?
Not urgent.
Other Relevant Parties
None
Related PRs
cf revisions
no longer reports EXPERIMENTAL notice [v7] #3060 - v7 (this PR)cf revisions
no longer reports EXPERIMENTAL notice [v8] #3061 - v8cf revisions
no longer reports EXPERIMENTAL notice [main] #3062 - main