Add --wait, -w flag to run-task #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @stephanme, can you please fix EasyCLA? So we can proceed with merging this PR. |
93ef5bf to
609dfb0
Compare
|
LGTM |
jdgonzaleza
approved these changes
Dec 15, 2022
d7280b3 to
eb80409
Compare
|
Hello, |
When the wait flag is supplied to run-task, the cli will not exit until the task enters a terminal state; SUCCEEDED or FAILED. The cli exits 0 when the task succeeds and exits 1 when the task fails. This improves the scriptability of tasks. They can be run serially in a script. Cherry-pick of 8671a5b (cloudfoundry#1861) to v8 Addresses Issue cloudfoundry#1104, cloudfoundry#2238 Authored-by: Zach Robinson <zrobinson@pivotal.io> Co-authored-by: Stephan Merker <stephan.merker@sap.com>
5d13e00 to
f3a39d4
Compare
ccjaimes
pushed a commit
that referenced
this pull request
Oct 12, 2023
When the wait flag is supplied to run-task, the cli will not exit until the task enters a terminal state; SUCCEEDED or FAILED. The cli exits 0 when the task succeeds and exits 1 when the task fails. This improves the scriptability of tasks. They can be run serially in a script. Cherry-pick of 8671a5b (#1861) to v8 Addresses Issue #1104, #2238 Authored-by: Zach Robinson <zrobinson@pivotal.io>
ccjaimes
added a commit
that referenced
this pull request
Oct 13, 2023
When the wait flag is supplied to run-task, the cli will not exit until the task enters a terminal state; SUCCEEDED or FAILED. The cli exits 0 when the task succeeds and exits 1 when the task fails. This improves the scriptability of tasks. They can be run serially in a script. Cherry-pick of 8671a5b (#1861) to v8 Addresses Issue #1104, #2238 Authored-by: Zach Robinson <zrobinson@pivotal.io> Co-authored-by: Stephan Merker <merker.stephan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the wait flag is supplied to run-task, the cli will not exit until the task enters a terminal state; SUCCEEDED or FAILED.
The cli exits 0 when the task succeeds and exits 1 when the task fails.
This improves the scriptability of tasks. They can be run serially in a script.
Cherry-pick of 8671a5b (#1861) to v8
Addresses Issue #1104, #2238
Authored-by: Zach Robinson zrobinson@pivotal.io
Co-authored-by: Stephan Merker stephan.merker@sap.com
Does this PR modify CLI v6, CLI v7, or CLI v8?
CLI v8
Description of the Change
Adds --wait flag to run-task command as available in CLI v7.
Why Is This PR Valuable?
This improves the scriptability of tasks. They can be run serially in a script.
The --wait flag is supported for the run-task command in v7.
Why Should This Be In Core?
New cmd line flag for existing core command.
Applicable Issues
#2238
Original issue for v7 was #1104
How Urgent Is The Change?
not urgent
Other Relevant Parties
n/a