Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait, -w flag to run-task #1861

Merged
merged 1 commit into from
May 4, 2021
Merged

Add --wait, -w flag to run-task #1861

merged 1 commit into from
May 4, 2021

Conversation

zrob
Copy link
Contributor

@zrob zrob commented Dec 6, 2019

When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Addresses Issue #1104


This affects v7 only.

Does not address the --log request in the associated issue.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/170160892

The labels on this github issue will be updated when the story is started.

@JenGoldstrich
Copy link
Contributor

Bumping this due to a user reaching out, we are planning on merging this PR for the first minor release post V7 GA :)!

@BitPatty
Copy link

BitPatty commented Oct 5, 2020

What's the state on this PR, is it still being tracked?

@a-b
Copy link
Member

a-b commented Jan 7, 2021

I'd like to follow up to see if this PR is still relevant.

@Kiemes
Copy link

Kiemes commented Jan 8, 2021

I would still like to get that feature. :)

@BitPatty
Copy link

BitPatty commented Jan 8, 2021

I would still like to get that feature. :)

Dito, would enormously improve the scriptability with the cf cli

@jkbschmid
Copy link

Any updates on this? I'd also like to use this in my scripts.

@a-b
Copy link
Member

a-b commented Apr 15, 2021

Our team is understaffed. It could take a while to get to this via the backlog.
If someone wants to expedite this feature, please consider fixing conflicts, making tests green.
We will prioritize PR review without merge conflicts.

When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Addresses Issue cloudfoundry#1104

Authored-by: Zach Robinson <zrobinson@pivotal.io>
@linux-foundation-easycla
Copy link

CLA Missing ID

@zrob zrob changed the base branch from master to v7 May 4, 2021 02:13
@zrob
Copy link
Contributor Author

zrob commented May 4, 2021

@a-b I've updated the PR to remove conflicts and to target v7 branch. hope that helps when you get a chance to review.

@a-b
Copy link
Member

a-b commented May 4, 2021

Thank you @zrob !
Can you please sign CLA by following EasyCLA directions so we can promptly merge your PR.

Copy link
Contributor

@reedr3 reedr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@a-b
Copy link
Member

a-b commented May 4, 2021

@zrob is employed by VMware, so we are going to proceed with this merge.

@a-b a-b merged commit 8671a5b into cloudfoundry:v7 May 4, 2021
stephanme added a commit to stephanme/cli that referenced this pull request Dec 8, 2022
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
a-b pushed a commit to stephanme/cli that referenced this pull request Dec 13, 2022
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
stephanme added a commit to stephanme/cli that referenced this pull request Dec 14, 2022
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
jdgonzaleza pushed a commit to stephanme/cli that referenced this pull request Dec 15, 2022
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
a-b pushed a commit to stephanme/cli that referenced this pull request Jun 8, 2023
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
stephanme added a commit to stephanme/cli that referenced this pull request Oct 12, 2023
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (cloudfoundry#1861) to v8
Addresses Issue cloudfoundry#1104, cloudfoundry#2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
Co-authored-by: Stephan Merker <stephan.merker@sap.com>
ccjaimes pushed a commit that referenced this pull request Oct 12, 2023
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (#1861) to v8
Addresses Issue #1104, #2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
ccjaimes pushed a commit that referenced this pull request Oct 12, 2023
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (#1861) to v8
Addresses Issue #1104, #2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>
ccjaimes added a commit that referenced this pull request Oct 13, 2023
When the wait flag is supplied to run-task, the cli will
not exit until the task enters a terminal state; SUCCEEDED or FAILED.

The cli exits 0 when the task succeeds and exits 1 when the task fails.

This improves the scriptability of tasks. They can be run
serially in a script.

Cherry-pick of 8671a5b (#1861) to v8
Addresses Issue #1104, #2238

Authored-by: Zach Robinson <zrobinson@pivotal.io>

Co-authored-by: Stephan Merker <merker.stephan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants