Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0030 Add support to Diego for file based service bindings #100

Merged
merged 18 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
178c67b
Extend models and proto-buffers definitions for SERVICE_BINDING_ROOT.
dimitardimitrov13 Jun 27, 2024
f3cc83a
Add some PoC code within desired_lrp_db.go
dimitardimitrov13 Jul 9, 2024
00eff6f
Add go.mod and go.sum for testing purpose.
dimitardimitrov13 Jul 9, 2024
61a941a
Add some PoC code within desired_lrp_db.go fix.
dimitardimitrov13 Jul 9, 2024
362e3fd
Add some PoC code within desired_lrp_db.go debug.
dimitardimitrov13 Jul 9, 2024
08c1154
Implementing service binding root size validator
dimitardimitrov13 Jul 11, 2024
62f0ed7
Extend test scenario.
dimitardimitrov13 Jul 11, 2024
5fa5162
Rename filesVariables to fileBasedServiceBinding and regenerating of …
dimitardimitrov13 Jul 18, 2024
ce00aa8
Merge branch 'main' into CFAR-929_VCAP_SERVICES
dimitardimitrov13 Jul 18, 2024
082bd22
Rename fileBasedServiceBinding to serviceBindingFiles.
dimitardimitrov13 Jul 19, 2024
ae1a93c
Adding of BDD tests for serviceBindingFiles.
dimitardimitrov13 Jul 22, 2024
27ddcad
Remove go.mod and go.sum
dimitardimitrov13 Jul 23, 2024
23ca56c
Unify protobuf defintion for Files in desired_lrp.proto
dimitardimitrov13 Jul 23, 2024
66a31b7
Addressing all linter issues.
dimitardimitrov13 Jul 24, 2024
55d01c7
Changes according Updates #1008
dimitardimitrov13 Oct 29, 2024
42d1af2
Merge branch 'main' into CFAR-929_VCAP_SERVICES
dimitardimitrov13 Oct 29, 2024
d4ca33a
Re-generating of desired_lrp.pb.go after conflicts.
dimitardimitrov13 Oct 29, 2024
9e990a7
Changes according to code review.
dimitardimitrov13 Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some PoC code within desired_lrp_db.go fix.
  • Loading branch information
dimitardimitrov13 committed Jul 9, 2024
commit 61a941a274f561caf1cc7f3efd3b4cef09ea624d
4 changes: 2 additions & 2 deletions db/sqldb/desired_lrp_db.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ func (db *SQLDB) DesiredLRPByProcessGuid(ctx context.Context, logger lager.Logge
return err
})

// PoC
var files []*models.Files
if desiredLRP.FilesVariables == nil {
desiredLRP.FilesVariables = []*models.Files{}
desiredLRP.FilesVariables = files
}

desiredLRP.FilesVariables = append(desiredLRP.FilesVariables, &models.Files{
Expand Down