RFC-0030 Add support to Diego for file based service bindings #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove scripts/generate_go_protos.sh. Restore models.go and remove PoC request.
ameowlia
requested changes
Dec 13, 2024
models/desired_lrp_test.go
Outdated
Comment on lines
126
to
127
| "suppress_log_output": false, | ||
| "volume_mounted_files": null |
There was a problem hiding this comment.
I see that this tabbing was weird before you were in the file, but can you fix it since you are in this file?
|
Hello @ameowlia, all comments were addressed. |
ameowlia
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is continuation for the RFC-0030
Backward Compatibility
Breaking Change? No
This feature is the first PoC for RFC-0030.
Since the CAPI implementation for RFC-0030 is not done yet, the PR doesn't need to be applied immediately.