Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TEXT bindings for plain text values in Miniflare #7738

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 11, 2025

Use text bindings for text values when passing to Miniflare. This gives parity with deployed behaviour.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor

@penalosa penalosa requested a review from a team as a code owner January 11, 2025 19:24
Copy link

changeset-bot bot commented Jan 11, 2025

🦋 Changeset detected

Latest commit: dce441c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 11, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-wrangler-7738

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7738/npm-package-wrangler-7738

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-wrangler-7738 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-workers-bindings-extension-7738 -O ./cloudflare-workers-bindings-extension.0.0.0-vae60025c8.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vae60025c8.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-create-cloudflare-7738 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-kv-asset-handler-7738

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-miniflare-7738

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-pages-shared-7738

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-unenv-preset-7738

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-vitest-pool-workers-7738

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-workers-editor-shared-7738

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-workers-shared-7738

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12748229551/npm-package-cloudflare-workflows-shared-7738

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the e2e Run e2e tests on a PR label Jan 13, 2025
@penalosa penalosa merged commit 8e9aa40 into main Jan 13, 2025
36 of 37 checks passed
@penalosa penalosa deleted the penalosa/miniflare-text-bindings branch January 13, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants